Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18469.
Pass
extract_drawingsto DOCX table conversion so disabling text-box extraction also suppresses text boxes anchored in table cells. The default still includes them.The public API regression saves a Word document with a body text box and a table text box. The original code fails the disabled case and passes the default control. Both pass on python-docx 0.8.11 and 1.2.0 with the fix. The original failing fixture also exports through the public API with
output=set. Configured file checks and normal commit hooks passed. Local testing covered DOCX conversion.If #18436 lands first, its new recursive table call should forward this same option when integrating the two changes.
AI-assisted implementation and testing with Codex.