Repository navigation
fix(doc2md): preserve OMML formula content - #18419
Open
FOWEPJF255 wants to merge 3 commits into
Open
FOWEPJF255 wants to merge 3 commits into
FOWEPJF255 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three OMML conversion paths can silently lose valid formula content because
convert_omathreturns an empty string after a handler exception or an operand is overwritten:accPr,barPr,dPr,groupChrPr, andfNamenodes may be absent. Use existing formatting defaults or retain the function expression.m:echildren. Collect all operands and rendersepChrbetween them, including a\middle|for a vertical bar.limLowbase outsidelim,min, andmaxpreviously raised. Render commoninf,sup, andgcdoperators directly and preserve other bases with\underset.Fixes #18408, #18409, #18410.
Validation
KeyErrororAttributeError, multi-expression delimiters retained only their last operand, and unsupportedlimLowbases raisedRuntimeError.python -m pytest tests/unit/test_doc2md_omml.py tests/unit/test_doc2md_omml_delimiter.py -q— 15 passed.git diff --checkpassed.