Repository navigation
Conversation
Word has built-in Heading 1-9 styles, but CommonMark ATX headings stop at six '#' markers, so Heading 7-9 were emitted as literal '####### ...' text. Clamp the detected level to 6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Word ships built-in
Heading 1–Heading 9styles, and_detect_heading_level()returned the style number as-is. CommonMark ATX headings allow at most six#, soHeading 7/8/9came out as literal####### …text and lost their heading status.Change
_detect_heading_level()now returnsmin(level, 6), matching its docstring ("1-6 = heading level"). Deep headings degrade to H6.Tests
tests/unit/test_doc2md_docx_headings.pybuilds a .docx withpython-docxthat uses Heading 1–9, and checks:_detect_heading_level()returns 1–6, 6, 6, 6DocxConverter().convert_file()emits at most six#for every heading.The 7/8/9 cases and the end-to-end test fail on
main, and all pass with the fix. They skip ifpython-docxis not installed.Fixes #18411
🤖 Generated with Claude Code