Skip to content

[SOT][3.14] Update the internal function to use PyObject_GC_Track replace _PyObject_GC_TRACK #78558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SigureMo merged 4 commits into from
Apr 2, 2026
+3 −2
Merged

[SOT][3.14] Update the internal function to use PyObject_GC_Track replace _PyObject_GC_TRACK #78558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee4abd0
fix: Update the internal function to use `_PyObject_GC_TRACK` replace…
gouzil Apr 1, 2026
439ae11
change ci group name -> SOT-314-debug
gouzil Apr 1, 2026
15b9a5e
fix: Force reinstall numpy with no cache for Python 3.14
gouzil Apr 2, 2026
94d959b
Revert "change ci group name -> SOT-314-debug"
SigureMo Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/run_sot_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function run_sot_test() {
run_and_check "Uninstalling numpy for Python 3.14..." \
$PYTHON_WITH_SPECIFY_VERSION -m pip uninstall -y "numpy"
run_and_check "Installing numpy>=2.3.5 for Python 3.14..." \
$PYTHON_WITH_SPECIFY_VERSION -m pip install "numpy>=2.3.5"
$PYTHON_WITH_SPECIFY_VERSION -m pip install --force-reinstall --no-cache-dir "numpy>=2.3.5"
fi

# cd to sot test dir
Expand Down
3 changes: 2 additions & 1 deletion paddle/fluid/pybind/sot/cpython_internals/internals_3_14.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ limitations under the License. */

#include <internal/pycore_code.h>
#include <internal/pycore_frame.h>
#include <internal/pycore_genobject.h>
#define Py_BUILD_CORE // internal/pycore_opcode.h need this macro
#define NEED_OPCODE_TABLES // To get _PyOpcode_Caches and _PyOpcode_Deopt

Expand Down Expand Up @@ -141,7 +142,7 @@ static void Internal_take_ownership(PyFrameObject *f,
PyErr_SetRaisedException(exc);
}
if (!_PyObject_GC_IS_TRACKED((PyObject *)f)) {
_PyObject_GC_TRACK((PyObject *)f);
PyObject_GC_Track((PyObject *)f);
}
Comment on lines 143 to 146
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says to replace PyObject_GC_Track with _PyObject_GC_TRACK, but the actual change does the opposite (switches _PyObject_GC_TRACK to PyObject_GC_Track). Please update the title (and/or description) to match the implemented fix to avoid confusion for reviewers and release notes.

Copilot uses AI. Check for mistakes.
Py_END_CRITICAL_SECTION();
}
Expand Down
Loading