Skip to content

馃 [Fix]: Pipeline no longer fails on a module repository with no releases #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Marius Storhaug (MariusStorhaug) wants to merge 1 commit into from
Closed

馃 [Fix]: Pipeline no longer fails on a module repository with no releases #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/actions/Resolve-PSModuleVersion/src/Resolve-PSModuleVersion.Helpers.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,9 @@ function Get-GitHubRelease {
Write-Error 'Failed to list releases for the repo.'
exit $LASTEXITCODE
}
$releases = $releasesJson | ConvertFrom-Json
# A repository that has never released returns '[]', which deserializes to nothing. Wrap the
# result so callers always receive an array, even for a module being bootstrapped.
$releases = @($releasesJson | ConvertFrom-Json)

Write-Host '-------------------------------------------------'
Write-Host ($releases | Select-Object -Property name, isPrerelease, isLatest, publishedAt |
Expand Down Expand Up @@ -327,6 +329,7 @@ function Get-LatestGitHubVersion {
param(
# The GitHub releases array to search.
[Parameter(Mandatory)]
[AllowEmptyCollection()]
[array] $Releases
)

Expand Down Expand Up @@ -474,6 +477,7 @@ function Get-NextPrereleaseNumber {

# The GitHub releases list.
[Parameter(Mandatory)]
[AllowEmptyCollection()]
[array] $Releases
)

Expand Down Expand Up @@ -551,6 +555,7 @@ function Get-NextModuleVersion {

# The GitHub releases list, used for incremental prerelease calculation.
[Parameter(Mandatory)]
[AllowEmptyCollection()]
[array] $Releases
)

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/Resolve-PSModuleVersion/src/main.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ $decision = if ($null -eq $pullRequest) {
Resolve-ReleaseDecision -Configuration $config -PullRequest $pullRequest
}

$releases = Get-GitHubRelease
$releases = @(Get-GitHubRelease)
$ghVersion = Get-LatestGitHubVersion -Releases $releases
$psGalleryVersion = Get-LatestPSGalleryVersion -ModuleName $actionInput.Name
$latestVersion = Get-LatestPublishedVersion -GitHubVersion $ghVersion -PSGalleryVersion $psGalleryVersion
Expand Down
Loading