[18.0][MIG] pos_transfer_account: Migration to 18.0 by P-H-Phuc · Pull Request #8 · P-H-Phuc/pos

P-H-Phuc · 2025-11-18T11:19:59Z

This module was written to extend the functionality of odoo Point Of Sale about transfer account.
This module is usefull only in a multi Point of Sale context of multi company context.
With this module, it is now allowed to define for each PoS config a transfer account.
If this account is set, it will be used when user realizes "Cash In/Out" operation.

Remove pos_transfer_account/models/cash_box_in.py and pos_transfer_account/models/cash_box_out.py: its model was removed from 14.0.

nguyenminhchien

Add unit tests

nguyenminhchien · 2025-11-21T03:15:45Z

the file name should be CONFIG.md or CONFIGURE.md. Please double check.

nguyenminhchien · 2025-11-21T04:05:10Z

+
+If this account is set, it will be used when user realizes "Put Money In" or
+"Take Money Out" operation, instead of the default one set in 'Invoicing' /
+'Configuration' / 'Setting' Section. ("Inter-Banks Transfer Account" field)


It's Suspense Account? on Journal

@P-H-Phuc You missed this comment. Note that, there is no "Inter-Banks Transfer Account" in 'Invoicing' / 'Configuration' / 'Setting'

nguyenminhchien · 2025-11-21T05:13:49Z

+        return super(
+            PosSession,
+            self.with_context(active_model="pos.session", active_ids=self.ids),
+        ).try_cash_in_out(_type, amount, reason, extras)


I don't know how you test this module. You even did not import the file account_bank_statement_line.py to your models/__init__.py.
Anw, please remove account_bank_statement_line.py. Then, add this code block:

from odoo import models class PosSession(models.Model): _inherit = "pos.session" def try_cash_in_out(self, _type, amount, reason, extras): if self.config_id.suspense_account_id: extras = extras or {} extras["counterpart_account_id"] = self.config_id.suspense_account_id.id return super().try_cash_in_out(_type, amount, reason, extras) def _prepare_account_bank_statement_line_vals(self, session, sign, amount, reason, extras): res = super()._prepare_account_bank_statement_line_vals(session, sign, amount, reason, extras) if extras.get("counterpart_account_id"): res["counterpart_account_id"] = extras["counterpart_account_id"] return res

nguyenminhchien · 2025-11-21T05:17:54Z

+class PosConfig(models.Model):
+    _inherit = "pos.config"
+
+    transfer_account_id = fields.Many2one(comodel_name="account.account")


Suggested change

transfer_account_id = fields.Many2one(comodel_name="account.account")

suspense_account_id = fields.Many2one(comodel_name="account.account")

to make it synchronize with the one created by Odoo SA.

nguyenminhchien · 2025-11-21T05:19:27Z

+class ResConfigSettings(models.TransientModel):
+    _inherit = "res.config.settings"
+
+    pos_transfer_account_id = fields.Many2one(


Suggested change

pos_transfer_account_id = fields.Many2one(

pos_suspense_account_id = fields.Many2one(

nguyenminhchien

2025-11-21 09:14:13,832 207521 INFO v18c_pos_transfer_account odoo.modules.loading: Loading module pos_transfer_account (56/56) 
2025-11-21 09:14:13,993 207521 INFO v18c_pos_transfer_account odoo.modules.registry: module pos_transfer_account: creating or updating database tables 
2025-11-21 09:14:14,113 207521 INFO v18c_pos_transfer_account odoo.modules.loading: loading pos_transfer_account/views/view_pos_config.xml 
2025-11-21 09:14:14,129 207521 INFO v18c_pos_transfer_account odoo.modules.loading: loading pos_transfer_account/views/res_config_settings_view.xml 
2025-11-21 09:14:14,162 207521 INFO v18c_pos_transfer_account odoo.modules.loading: Module pos_transfer_account: loading demo 
2025-11-21 09:14:14,162 207521 INFO v18c_pos_transfer_account odoo.modules.loading: loading pos_transfer_account/demo/account_account.xml 
2025-11-21 09:14:14,179 207521 INFO v18c_pos_transfer_account odoo.modules.loading: loading pos_transfer_account/demo/pos_config.xml 
2025-11-21 09:14:14,182 207521 WARNING v18c_pos_transfer_account odoo.modules.loading: Module pos_transfer_account demo data failed to install, installed without demo data 
Traceback (most recent call last):
  File "/home/chien/code/odoo/odoo/18.0/odoo/tools/convert.py", line 544, in _tag_root
    f(rec)
  File "/home/chien/code/odoo/odoo/18.0/odoo/tools/convert.py", line 444, in _tag_record
    record = model._load_records([data], self.mode == 'update')
  File "/home/chien/code/odoo/odoo/18.0/odoo/models.py", line 5502, in _load_records
    data['record']._load_records_write(data['values'])
  File "/home/chien/code/odoo/odoo/18.0/odoo/models.py", line 5420, in _load_records_write
    self.write(values)
  File "/home/chien/code/odoo/odoo/18.0/addons/point_of_sale/models/pos_config.py", line 543, in write
    result = super(PosConfig, self).write(vals)
  File "/home/chien/code/odoo/odoo/18.0/odoo/models.py", line 4741, in write
    raise ValueError("Invalid field %r on model %r" % (fname, self._name))
ValueError: Invalid field 'transfer_account_id' on model 'pos.config'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/chien/code/odoo/odoo/18.0/odoo/modules/loading.py", line 90, in load_demo
    load_data(env(su=True), idref, mode, kind='demo', package=package)
  File "/home/chien/code/odoo/odoo/18.0/odoo/modules/loading.py", line 72, in load_data
    tools.convert_file(env, package.name, filename, idref, mode, noupdate, kind)
  File "/home/chien/code/odoo/odoo/18.0/odoo/tools/convert.py", line 615, in convert_file
    convert_xml_import(env, module, fp, idref, mode, noupdate)
  File "/home/chien/code/odoo/odoo/18.0/odoo/tools/convert.py", line 686, in convert_xml_import
    obj.parse(doc.getroot())
  File "/home/chien/code/odoo/odoo/18.0/odoo/tools/convert.py", line 601, in parse
    self._tag_root(de)
  File "/home/chien/code/odoo/odoo/18.0/odoo/tools/convert.py", line 557, in _tag_root
    raise ParseError('while parsing %s:%s, somewhere inside\n%s' % (
odoo.tools.convert.ParseError: while parsing /home/chien/code/oca/pos/18.0/pos_transfer_account/demo/pos_config.xml:3, somewhere inside
<record id="pos_config_specific_transfer_account" model="pos.config">
        <field name="name">Point Of Sale with Specific Transfer Account</field>
        <field name="transfer_account_id" ref="account_pos_transfer_account"/>
        <field name="company_id" ref="base.main_company"/>
    </record>
2025-11-21 09:14:14,203 207521 INFO v18c_pos_transfer_account odoo.modules.loading: Module pos_transfer_account loaded in 0.37s, 209 queries (+209 other)

nguyenminhchien

Update DESCRIPTION.md following a comment in my previous review

P-H-Phuc · 2025-11-24T08:01:52Z

Resolved!

P-H-Phuc · 2025-11-25T04:42:08Z

Reference to OCA: https://github.com/OCA/pos/pull/1459

P-H-Phuc · 2026-03-02T09:50:13Z

@nguyenminhchien Could you please review this module? The update is based on the new request: https://tms.trobz.com/web#id=66226&action=543&model=tms.forge.ticket&view_type=form&cids=1&menu_id=424

nguyenminhchien · 2026-03-03T03:52:19Z

+        suspense_account = session.config_id.suspense_account_id
+        if not suspense_account:
+            suspense_account = session.company_id.transfer_account_id
+        res["counterpart_account_id"] = suspense_account.id


No, don't force the "counterpart_account_id" to be "suspense_account". Do update in the case of take money in / out only.
keep the logic as before

just adjust the value of suspense account.

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch from 5cf6ad2 to 22a9c03 Compare November 19, 2025 08:45

nguyenminhchien suggested changes Nov 21, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch from 22a9c03 to 511589f Compare November 21, 2025 08:40

P-H-Phuc requested a review from nguyenminhchien November 21, 2025 08:42

nguyenminhchien suggested changes Nov 21, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch from 511589f to 0cd2a51 Compare November 24, 2025 04:18

nguyenminhchien suggested changes Nov 24, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch from 0cd2a51 to 2612349 Compare November 24, 2025 07:58

P-H-Phuc requested a review from nguyenminhchien November 24, 2025 09:24

nguyenminhchien approved these changes Nov 25, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch from 2612349 to 75c957f Compare March 2, 2026 09:47

P-H-Phuc requested a review from nguyenminhchien March 2, 2026 09:50

nguyenminhchien suggested changes Mar 3, 2026

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch from 75c957f to a90c85d Compare March 3, 2026 04:26

P-H-Phuc requested a review from nguyenminhchien March 3, 2026 11:05

OCA-git-bot force-pushed the 18.0-mig-pos_transfer_account branch from a90c85d to f1d9bf7 Compare April 9, 2026 18:17

nguyenminhchien and others added 2 commits May 4, 2026 12:00

[ADD] pos_transfer_account

13fe0c0

[IMP] pos_transfer_account: pre-commit auto fixes

bd22d3f

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch 4 times, most recently from c82a758 to 7f38b1b Compare May 5, 2026 07:55

[MIG] pos_transfer_account: Migration to 18.0

f09a908

P-H-Phuc force-pushed the 18.0-mig-pos_transfer_account branch from 7f38b1b to f09a908 Compare May 5, 2026 07:58

	transfer_account_id = fields.Many2one(comodel_name="account.account")
	suspense_account_id = fields.Many2one(comodel_name="account.account")

	pos_transfer_account_id = fields.Many2one(
	pos_suspense_account_id = fields.Many2one(

Conversation

P-H-Phuc commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

P-H-Phuc commented Nov 24, 2025

Uh oh!

P-H-Phuc commented Nov 25, 2025

Uh oh!

P-H-Phuc commented Mar 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

P-H-Phuc commented Nov 18, 2025 •

edited

Loading