Skip to content

fix: build P2ID asset from vault entry to match callback-flag vault keys #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeljkoX merged 7 commits into from
Jul 24, 2026
Merged

fix: build P2ID asset from vault entry to match callback-flag vault keys #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d806b3
fix: build P2ID asset from vault entry to match callback-flag vault keys
0xnullifier Jul 22, 2026
96a6514
fix: resolve P2ID vault lookup from the web client store, not the sna…
0xnullifier Jul 23, 2026
72eb1ac
refactor: extract Multisig.getStoreAccount and use it in the browser …
0xnullifier Jul 23, 2026
44d5522
fix: fall back to a directly constructed P2ID asset when the faucet i…
0xnullifier Jul 23, 2026
a295f4f
fix: error in both SDKs when the P2ID faucet asset is absent from the…
0xnullifier Jul 23, 2026
7fbe2f4
Revert "fix: error in both SDKs when the P2ID faucet asset is absent …
0xnullifier Jul 23, 2026
7b8ff7b
Merge remote-tracking branch 'origin/main' into utkarsh/p2id-vault-ke…
0xnullifier Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,195 changes: 1,019 additions & 176 deletions examples/_shared/multisig-browser/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion examples/_shared/multisig-browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@getpara/react-sdk-lite": "2.17.0",
"@getpara/solana-wallet-connectors": "2.17.0",
"@miden-sdk/miden-para": "0.15.1",
"@miden-sdk/miden-sdk": "0.15.7",
"@miden-sdk/miden-sdk": "0.15.8",
"@miden-sdk/react": "0.15.7",
"@miden-sdk/use-miden-para-react": "0.15.1",
"@openzeppelin/guardian-client": "file:../../../packages/guardian-client",
Expand Down
11 changes: 7 additions & 4 deletions examples/_shared/multisig-browser/src/multisigApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,15 +397,17 @@ export interface CustomProposalRecipe {
saltHex: string;
}

function buildRequestFromRecipe(
async function buildRequestFromRecipe(
multisig: Multisig,
recipe: CustomProposalRecipe,
signatureAdviceMap?: AdviceMap,
): TransactionRequest {
): Promise<TransactionRequest> {
return buildP2idTransactionRequest(
recipe.senderId,
recipe.recipientId,
recipe.faucetId,
BigInt(recipe.amount),
await multisig.getStoreAccount(),
{ salt: Word.fromHex(recipe.saltHex), signatureAdviceMap },
).request;
}
Expand All @@ -423,6 +425,7 @@ export async function createCustomP2idProposal(
recipientId,
faucetId,
amount,
await multisig.getStoreAccount(),
);

const created = await createProposalResult(multisig, () =>
Expand All @@ -445,10 +448,10 @@ export async function prepareAndSubmitCustomProposal(
multisig: Multisig,
recipe: CustomProposalRecipe,
): Promise<void> {
const bindingRequestBytes = buildRequestFromRecipe(recipe).serialize();
const bindingRequestBytes = (await buildRequestFromRecipe(multisig, recipe)).serialize();
const advice = await multisig.prepareCustomExecution(recipe.proposalId, bindingRequestBytes);

const finalRequest = buildRequestFromRecipe(recipe, advice);
const finalRequest = await buildRequestFromRecipe(multisig, recipe, advice);

try {
await multisig.submitTransaction(finalRequest);
Expand Down
Loading
Loading