Remove legacy network HTTP APIs#390
Draft
silug wants to merge 4 commits intoOpenVoxProject:mainfrom
Draft
Conversation
The deprecated Puppet::Network::HTTP::Connection class and associated legacy HTTP pool methods have been removed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
silug
force-pushed
the
remove-legacy-http-apis
branch
from
8b7c52f to
8f76945
Compare
`dir_containing` creates the input `.rb` files just before `genface.types` runs and creates the output `.pp` files. On Windows with Ruby 3.2, sub-second or 2-second filesystem timestamp granularity can make test2.rb's mtime appear >= test2.pp's mtime, causing `up_to_date?` to return false incorrectly. The fix backdates both input `.rb` files by 10 seconds before the first `genface.types` run, so the generated `.pp` files will always have unambiguously newer mtimes regardless of filesystem timestamp granularity. The `sleep(1)` before `touch`ing test1.rb is still needed to ensure test1.rb's new mtime is clearly newer than test1.pp's mtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Replace File.utime-based workaround with a sleep(2) before the first genface.types call. File.utime with an explicit Time argument has a DST offset bug on Windows Ruby 3.2 that can shift the stored mtime by ±1 hour, making the input files appear to be in the future and causing spurious regeneration. Sleeping 2 seconds instead ensures output files have unambiguously newer mtimes than inputs on any filesystem, including FAT with its 2-second timestamp granularity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The deprecated Puppet::Network::HTTP::Connection class and associated legacy HTTP pool methods have been removed.
Closes #341
Checklist
I have:
Signed-off-byannotation to each of my commits