remove SHA1 fallback from CertificateSigner#381
Draft
silug wants to merge 1 commit intoOpenVoxProject:mainfrom
Draft
remove SHA1 fallback from CertificateSigner#381silug wants to merge 1 commit intoOpenVoxProject:mainfrom
silug wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
SHA1 is no longer considered safe for use in X.509 signing and has been removed from modern OpenSSL builds. Drop it from the digest fallback chain in CertificateSigner so it is never selected, and update the corresponding spec to reflect the new SHA256 -> SHA512 -> SHA384 -> SHA224 precedence order. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Contributor
Author
|
This is a breaking change that should be considered for OpenVox 9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
SHA1 is no longer considered safe for use in X.509 signing and has been removed from modern OpenSSL builds. Drop it from the digest fallback chain in CertificateSigner so it is never selected, and update the corresponding spec to reflect the new SHA256 -> SHA512 -> SHA384 -> SHA224 precedence order.
Checklist
I have:
Signed-off-byannotation to each of my commits