front: add bbox fetching and viewport adjustment - #18052
Open
flomonster wants to merge 2 commits into
Open
Conversation
Integrated for Editor, ItineraryModalMap, and Map components. Signed-off-by: Florian Amsallem <florian.amsallem@gmail.com>
flomonster
force-pushed
the
fam/map-auto-focus
branch
from
August 7, 2026 16:57
3f17958 to
f238c14
Compare
emersion
self-requested a review
August 7, 2026 17:38
emersion
reviewed
Aug 7, 2026
emersion
reviewed
Aug 7, 2026
|
|
||
| void getInfraByInfraIdBbox({ infraId: infraID }) | ||
| .unwrap() | ||
| .then((infraBbox) => { |
Member
There was a problem hiding this comment.
async/await should be preferred over the callback-based Promise API.
emersion
reviewed
Aug 7, 2026
| } | ||
| }, [urlInfra]); | ||
|
|
||
| useEffect(() => { |
Member
There was a problem hiding this comment.
useEffect() isn't a great thing to use here. useQuery() + useMemo() would be better. Redux usage makes things a bit painful here.
flomonster
force-pushed
the
fam/map-auto-focus
branch
from
August 7, 2026 18:55
e28b7e5 to
ed95278
Compare
flomonster
force-pushed
the
fam/map-auto-focus
branch
from
August 7, 2026 19:08
ed95278 to
918e037
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated for Editor, ItineraryModalMap, and Map components.
close https://github.com/osrd-project/osrd-confidential/issues/1286