Conversation
osrd-ui needs a few changes for TypeScript v6 compatibility: - `baseUrl` needs to be dropped because it's now deprecated and causes warnings (and thus CI failures). - `paths` had a bogus unused entry, TypeScript now complains that it's not a relative path. - `noUncheckedSideEffectImports` now defaults to true. This causes failures because we import .css files. A better way to solve this would be to `declare module '*.css'`, but that's cumbersome to apply to all osrd-ui packages. For now, let's just explicitly set this config option to the v5 default. Signed-off-by: Simon Ser <contact@emersion.fr>
github-actions
bot
added
area:front
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osrd-ui needs a few changes for TypeScript v6 compatibility:
baseUrlneeds to be dropped because it's now deprecated and causes warnings (and thus CI failures).pathshad a bogus unused entry, TypeScript now complains that it's not a relative path.noUncheckedSideEffectImportsnow defaults to true. This causes failures because we import .css files. A better way to solve this would be todeclare module '*.css', but that's cumbersome to apply to all osrd-ui packages. For now, let's just explicitly set this config option to the v5 default.