Skip to content

Add tests for useCategoryColors hook#16214

Open
achrafmohye wants to merge 2 commits intodevfrom
ame/add-useCategoryColors-tests
Open

Add tests for useCategoryColors hook#16214
achrafmohye wants to merge 2 commits intodevfrom
ame/add-useCategoryColors-tests

Conversation

@achrafmohye
Copy link
Copy Markdown
Contributor

@achrafmohye achrafmohye commented Apr 13, 2026

No description provided.

@achrafmohye
front: add tests for useCategoryColors hook
497cb9b 
Signed-off-by: achrafmohye <a.mohyeddine@gmail.com>
@achrafmohye achrafmohye requested a review from a team as a code owner April 13, 2026 09:06
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Apr 13, 2026
@achrafmohye achrafmohye self-assigned this Apr 13, 2026
@Yohh
Copy link
Copy Markdown
Contributor

Yohh commented Apr 13, 2026 •
edited
Loading

Note

following the origin of useSubCategoryContext then SubCategoryContextProvider I'm not sure if we really need all the subCategoryContext.tsx logic, it seems a bit over-engineerd or lacks documentation
in fact SubCategoryContextProvider is a hook, should be named useSubCategoryContextProvider and maybe should be tested

Yohh
Yohh reviewed Apr 13, 2026
View reviewed changes
@achrafmohye
fixup: review comments
5ec2ffd 
Signed-off-by: achrafmohye <a.mohyeddine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yohh Yohh Yohh left review comments

@Signez Signez Awaiting requested review from Signez

@SharglutDev SharglutDev Awaiting requested review from SharglutDev

At least 0 approving reviews are required to merge this pull request.

Assignees

@achrafmohye achrafmohye

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achrafmohye @Yohh