Skip to content

refactor method table handling - #14

Merged
yhteoh merged 2 commits into
v1.0from
refactor
Sep 2, 2026
Merged

yhteoh merged 2 commits into
v1.0from
refactor

Conversation

@yhteoh

@yhteoh yhteoh commented Sep 2, 2026

Copy link
Copy Markdown
Contributor
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    refactor

  • What is the current behavior? (You can also link to an open issue here)

  • Method table not stateless, it is tracking the time
  • MethodTableRegistry not used
  • No options class for method tables
  • What is the new behavior (if this is a feature change)?
  • Moved machine time tracking from method table to vm
  • Refactored code to make use of MethodTableRegistry in AnalogInterpreter and AnalogVM
  • Moved AnalogVMNULL to oqd_analog_emulator.instructions
  • Created MethodTableOptionsBase as base class for options for method tables
  • Changed MethodTable run methods arguments from (stack, store, registers) to vm
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

Refactored code to make use of MethodTableRegistry in AnalogInterpreter and AnalogVM
Moved AnalogVMNULL to oqd_analog_emulator.instructions
Created MethodTableOptionsBase as base class for options for method tables
Moved machine time tracking from method table to vm
Changed MethodTable run methods arguments from (stack, store, registers) -> vm
@yhteoh
yhteoh requested a review from vishnu-m77 September 2, 2026 16:49
@yhteoh
yhteoh merged commit 9c4cf4f into v1.0 Sep 2, 2026
12 checks passed
@yhteoh
yhteoh deleted the refactor branch September 2, 2026 18:06
@yhteoh yhteoh added the refactor Refactor label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant