Repository navigation
fix(audio-energy): handle fractional video duration windows - #720
Merged
calesthio merged 1 commit intoNov 8, 2026
Merged
Conversation
sethshoultes
added a commit
to sethshoultes/OpenMontage
that referenced
this pull request
Oct 28, 2026
…and footnote, larger labels (designer CHANGE on OpenMontageInc#720) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
sethshoultes
added a commit
to sethshoultes/OpenMontage
that referenced
this pull request
Oct 28, 2026
…e (10s hold), home page labels, bigger footnote, dagger on the tool slide (designer CHANGE on the silent cut, OpenMontageInc#720) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
calesthio
approved these changes
Nov 7, 2026
calesthio
left a comment
calesthio
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for correcting fractional audio-energy windows. Reviewed the complete diff against main 63d1087a: positive finite validation, ceiling bucket count, and final-window bounds preserve the remainder without reading past the audio. Validation: isolated offline focused audio-energy suite — 7 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The best-window search truncates video duration to an integer. A 0.5-second video produces an empty window and divides by zero; 1.5 seconds is scored as one second. A loud partial final bucket can also be selected despite insufficient audio remaining, incorrectly recommending looping.
Round up to the existing one-second analysis bucket size, restrict candidate starts to those that fit the actual audio duration, and reject nonpositive/nonfinite requested durations with a tool error.
Validation: all 7 regression cases fail before and pass after the change. Also ran the real ffprobe/ebur128 flow against a generated 2-second WAV with a 0.5-second target; it returns a fitting offset successfully. No provider calls.
Checked open/closed audio_energy, fractional, and loudness PRs/issues; existing loudness changes target audio_mixer, not this analysis tool.