Repository navigation
fix(subtitle): preserve literal backslashes in correction values - #718
Merged
calesthio merged 1 commit intoNov 8, 2026
Merged
Conversation
calesthio
approved these changes
Nov 7, 2026
calesthio
left a comment
calesthio
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for fixing literal correction replacements. Reviewed the complete diff against main 63d1087a: the replacement callback preserves literal backslashes and group-like text without mutating input segments. Validation: isolated offline correction/timestamp suites — 8 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segment-level subtitle corrections pass replacement strings directly to
re.sub. A literal correction such asC:\Users\speakerraisesre.PatternError,\1is treated as a nonexistent capture group, andline\ntextsilently becomes two lines. Word-level corrections already preserve the same values literally.Return the replacement from a callback so segment-level corrections preserve literal text too. Add three end-to-end SRT-generation regressions and a consistency test for segment/word corrections; all four fail before the fix.
Validation: 8 subtitle correction/timestamp tests pass. Tests write only temporary subtitle files; no provider calls. Searched existing subtitle/corrections/escape issues and PRs, including #538 (CJK spacing).