Repository navigation
Fix BarChart value label precision - #656
Merged
calesthio merged 1 commit intoNov 8, 2026
Merged
Conversation
SanHsien
added a commit
to SanHsien/OpenMontage
that referenced
this pull request
Sep 15, 2026
…iage, branch cleanup, and main branch protection
calesthio
approved these changes
Nov 7, 2026
calesthio
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for separating data-label precision from axis-tick formatting. Reviewed the complete diff against main 63d1087a. The existing K/M abbreviations remain, while smaller fractional values preserve their supplied precision. Validation: focused contract passed; additionally executed the actual production formatter in Node: 0.015, 0.0004 and 1.2345 remain exact, with 1200 still displayed as 1.2K. This is the preferred precise-label fix over #754; consolidate them rather than merging both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the precision of fractional values in
BarChartvalue labels so the annotations match the data used to draw each bar.Related issue
Closes #654
Changes
Testing
npx tsc --noEmit --pretty false(pass)python -m pytest tests/contracts/test_bar_chart_format_contract.py -q(pass)google.genaipackage.Checklist
make test-contracts/make test) where applicable; the suite is limited by the unavailable optional Google dependency noted above.