Repository navigation
Fix Pond5 provider contract - #653
Merged
1 commit merged intoNov 8, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
Require Pond5 credentials, propagate API failures, and document the authenticated-only source accurately. Add regression coverage for availability, credentials, and status errors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
calesthio
approved these changes
Nov 7, 2026
calesthio
left a comment
calesthio
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for making Pond5 availability and failures honest. Reviewed the complete diff against main 63d1087a: missing credentials no longer advertise availability, configured credentials stay on the API request, and failed searches propagate instead of returning a fabricated empty fallback. Pond5's official API page describes partner API access (https://www.pond5.com/api). Validation: adapter suite 39 passed, 2 expected failures for unrelated adapters. Transport is mocked; partner endpoint/authentication was not exercised with a live account, and this review does not claim it was.
calesthio
pushed a commit
to manish511-github/OpenMontage
that referenced
this pull request
Nov 8, 2026
# Conflicts: # tests/tools/test_stock_source_adapters.py
calesthio
pushed a commit
to manish511-github/OpenMontage
that referenced
this pull request
Nov 8, 2026
…c#815 Adapted from PR OpenMontageInc#815 by @serdarucel: retain deterministic shape and PYTHONHASHSEED subprocess coverage with canonical PR OpenMontageInc#597 stable_url_id (16 hexadecimal characters). The cohort preserves the original reviewed heads for OpenMontageInc#594, OpenMontageInc#595, OpenMontageInc#597, OpenMontageInc#639, OpenMontageInc#652, OpenMontageInc#653, OpenMontageInc#779 and OpenMontageInc#857. No audio or Pixabay retry implementations are included.
calesthio
closed this pull request by merging all changes
into
OpenMontageInc:main
in
82d2601
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POND5_API_KEYbefore advertising Pond5 Public Domain availability.StockSource.searchcontract instead of falling through to an empty web-scraper stub.Validation
python -m pytest -q tests/tools/test_stock_source_adapters.py tests/tools/test_corpus_builder_total_failure.py— 43 passed, 2 pre-existing xfailed (Archive.org/Wikimedia)python -m py_compile tools/video/stock_sources/pond5_pd.py tests/tools/test_stock_source_adapters.pygit diff --checkNo secrets or
.envfiles are included.