Skip to content

Fix Pexels and Pixabay provider preflight detection - #651

Merged
calesthio merged 1 commit into
OpenMontageInc:mainfrom
abuashiks22-crypto:abuashiks22-crypto-fix-stock-provider-detection
Nov 8, 2026
Merged

calesthio merged 1 commit into
OpenMontageInc:mainfrom
abuashiks22-crypto:abuashiks22-crypto-fix-stock-provider-detection

Conversation

@abuashiks22-crypto

Copy link
Copy Markdown

Summary

  • declare Pexels/Pixabay API-key dependencies in the provider registry
  • treat blank or whitespace-only environment values as missing while preserving non-empty process values
  • load configured .env values when process variables are blank, without exposing credentials
  • add focused provider detection and env-loading tests

Validation

  • python -m pytest tests/tools/test_stock_provider_detection.py tests/tools/test_pixabay_per_page_clamp.py tests/tools/test_stock_source_adapters.py -q — 45 passed, 3 xfailed
  • exact provider_menu_summary() preflight with safe dummy process values reported available providers pexels and pixabay; all four image/video tools reported available
  • blank key verification reported all four tools unavailable
  • git diff --check passed

No secrets or .env files were committed; only the tracked .env.example exists in the repository.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@calesthio calesthio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for repairing stock-provider detection. Reviewed all dependency metadata, blank-key checks and the two env-loading paths against docs/PR_REVIEW_GUIDE.md. The new behavior fills blank process values from configured entries while preserving nonblank process values, and key-backed tools now advertise their dependencies honestly. Clean integration with current main: pytest tests/tools/test_stock_provider_detection.py tests/tools/test_pixabay_per_page_clamp.py tests/tools/test_stock_source_adapters.py -q --tb=short -p no:cacheprovider passed 45 tests with 3 existing expected failures. No credentials or live provider calls were used.

@calesthio calesthio closed this Nov 7, 2026
@calesthio calesthio reopened this Nov 7, 2026
calesthio pushed a commit that referenced this pull request Nov 8, 2026
@calesthio
calesthio merged commit ddacf60 into OpenMontageInc:main Nov 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants