Repository navigation
feat(video_compose): allow a job-scoped browser executable for Remotion renders - #620
Merged
calesthio merged 1 commit intoNov 8, 2026
Conversation
…ion renders Remotion renders default to locating a browser automatically (bundled Chromium or system default). On locked-down or heterogeneous machines (e.g. air-gapped Windows setups, pinned enterprise browser binaries, or multi-job workflows), passing an explicit browser binary is necessary. - Add remotion_browser_executable to VideoCompose.input_schema. - Add _append_remotion_browser_executable() helper validating file existence and appending --browser-executable=<path>. - Wire into both standard _remotion_render and atelier render paths. - Forward from execute(operation="render") high-level entrypoint. Tests: test flag pass-through, fail-fast on nonexistent file, high-level forwarding, omitted flag case, and atelier mode pass-through. Closes OpenMontageInc#619
calesthio
approved these changes
Nov 7, 2026
calesthio
left a comment
calesthio
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding a job-scoped browser override. I reviewed the full diff and the standard/atelier command construction: the path is validated before execution, passed as one argv element, and forwarded through the high-level render path. In a clean checkout, python -m pytest -q -p no:cacheprovider tests/tools/test_remotion_diagnostics.py passed 10 tests, including the new standard, atelier, missing-file and absent-option cases. The flag matches Remotion's documented CLI. No browser install, live provider call or full video render was performed. https://www.remotion.dev/docs/cli/render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #619.
What
�ideo_compose's Remotion path always let Remotion locate a browser automatically (bundled Chromium or system default). On locked-down or heterogeneous machines (such as air-gapped workstations, pinned enterprise Chromium/Edge installs, or multi-job workflows with isolated runtimes), passing an explicit browser binary is necessary.
emotion_browser_executable property to VideoCompose.input_schema.
emotion_browser_executable through the high-level _render() entry point.
Backwards-compatible: when omitted, behavior is identical to current upstream.
Tests
Added 5 tests in ests/tools/test_remotion_diagnostics.py:
All 10 tests in est_remotion_diagnostics.py pass.