Repository navigation
feat(composer): pass cut fontSize/titleFontSize through to CalloutBox - #607
Merged
calesthio merged 1 commit intoNov 8, 2026
Conversation
CalloutBox already accepts optional fontSize/titleFontSize props, but the Explainer cut path never forwarded them, so callout cuts could not control their own typography while text_card cuts could. Declare titleFontSize on the Cut interface (fontSize already existed), forward both in SceneRenderer, and document the fields for the callout scene type.
calesthio
approved these changes
Nov 7, 2026
calesthio
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for exposing the existing CalloutBox typography controls. I reviewed both changed files and confirmed that fontSize and titleFontSize are optional supported props with component defaults, the Cut interface already contains fontSize, and the new optional titleFontSize is forwarded correctly. Omitting both retains component defaults. This is a focused pass-through; no render was run because this clean checkout does not have the Remotion dependency tree installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CalloutBoxalready accepts optionalfontSize/titleFontSizeprops, but the Explainer cut path never forwarded them — callout cuts were stuck on the component defaults whiletext_cardcuts could size their own typography. This bit long/dense callout text (e.g. Turkish quote callouts) that needed smaller body text than the 32px default.Change
cut.fontSize/cut.titleFontSizeinSceneRenderer's callout branch.titleFontSize?: numberon theCutinterface (fontSizealready existed) so the pass-through is type-safe.calloutrow inSCENE_TYPES.md.Testing
Pure props pass-through; both props already exist on the component with defaults (32/38), so omitting them is unchanged behavior. CI has no Node job, so no composer test suite applies; verified the fields exist on both ends and the interface now covers the access.