Skip to content

feat(composer): pass cut fontSize/titleFontSize through to CalloutBox - #607

Merged
calesthio merged 1 commit into
OpenMontageInc:mainfrom
algoritimbilisim:feat/explainer-callout-fontsize
Nov 8, 2026
Merged

calesthio merged 1 commit into
OpenMontageInc:mainfrom
algoritimbilisim:feat/explainer-callout-fontsize

Conversation

@algoritimbilisim

Copy link
Copy Markdown
Contributor

Problem

CalloutBox already accepts optional fontSize / titleFontSize props, but the Explainer cut path never forwarded them — callout cuts were stuck on the component defaults while text_card cuts could size their own typography. This bit long/dense callout text (e.g. Turkish quote callouts) that needed smaller body text than the 32px default.

Change

  • Forward cut.fontSize / cut.titleFontSize in SceneRenderer's callout branch.
  • Declare titleFontSize?: number on the Cut interface (fontSize already existed) so the pass-through is type-safe.
  • Document both fields on the callout row in SCENE_TYPES.md.

Testing

Pure props pass-through; both props already exist on the component with defaults (32/38), so omitting them is unchanged behavior. CI has no Node job, so no composer test suite applies; verified the fields exist on both ends and the interface now covers the access.

CalloutBox already accepts optional fontSize/titleFontSize props, but
the Explainer cut path never forwarded them, so callout cuts could not
control their own typography while text_card cuts could. Declare
titleFontSize on the Cut interface (fontSize already existed), forward
both in SceneRenderer, and document the fields for the callout scene
type.

@calesthio calesthio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for exposing the existing CalloutBox typography controls. I reviewed both changed files and confirmed that fontSize and titleFontSize are optional supported props with component defaults, the Cut interface already contains fontSize, and the new optional titleFontSize is forwarded correctly. Omitting both retains component defaults. This is a focused pass-through; no render was run because this clean checkout does not have the Remotion dependency tree installed.

@calesthio calesthio closed this Nov 7, 2026
@calesthio calesthio reopened this Nov 7, 2026
@calesthio
calesthio merged commit 09442c1 into OpenMontageInc:main Nov 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants