-
Notifications
You must be signed in to change notification settings - Fork 1
Prolif class implementation #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
talagayev
wants to merge
20
commits into
main
Choose a base branch
from
prolif_class_implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
93d39f5
added prolif in environment.yml
talagayev 5f48f14
black format
talagayev 2ae6357
modified for AnalysisBase
talagayev 976722d
black formatting
talagayev abed811
added tests
talagayev 47060fb
Merge branch 'main' into prolif_class_implementation
talagayev 445feb8
Added 2D visualizationa and adressed comments
talagayev a673636
Added tests
talagayev bf4723a
added args for selection
talagayev 3e9a2b4
black formatting
talagayev 76b87f4
Merge branch 'main' into prolif_class_implementation
talagayev 990c86f
adjusted test error
talagayev d964589
Merge branch 'prolif_class_implementation' of https://github.com/Open…
talagayev 23e218b
adjusted tests
talagayev 2d1f22e
adjusted code to add additional visualization and changed the wrapper
talagayev 81a3fa9
Merge branch 'main' into prolif_class_implementation
talagayev 15e8620
Merge branch 'main' into prolif_class_implementation
hannahbaumann 76037b5
Merge branch 'main' into prolif_class_implementation
talagayev 0d8779a
Moving plots to plotting
talagayev a210c3f
Adjusting style
talagayev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ dependencies: | |
| - openff-units | ||
| - pip | ||
| - tqdm | ||
| - prolif | ||
| - pyyaml | ||
| # for testing | ||
| - coverage | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add the dependency to the pyproject.toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes can do :)