[WIP] warehouse: docs#1988
Draft
atravitz wants to merge 6 commits into
Draft
Conversation
|
No API break detected ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/warehouse #1988 +/- ##
==================================================
+ Coverage 90.33% 90.34% +0.01%
==================================================
Files 212 212
Lines 20086 20092 +6
==================================================
+ Hits 18144 18152 +8
+ Misses 1942 1940 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
atravitz
commented
Jun 5, 2026
| Parameters | ||
| ---------- | ||
| setup : ExternalStorage | ||
| setup : RequiredExternalStorage |
Contributor
Author
There was a problem hiding this comment.
I know Required is the default, but can we be explicit here for the sake of documentation?
Also, do we want to actually validate this? Otherwise it won't fail until there's a key error when someone tries to access .result_store.
atravitz
commented
Jun 5, 2026
Comment on lines
19
to
20
| def test_store_protocol_dag_result(self): | ||
| pytest.skip("Not implemented yet") |
Contributor
Author
There was a problem hiding this comment.
what is the plan for this?
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin