Skip to content

[WIP] warehouse: docs#1988

Draft
atravitz wants to merge 6 commits into
feat/warehousefrom
warehouse/docs
Draft

[WIP] warehouse: docs#1988
atravitz wants to merge 6 commits into
feat/warehousefrom
warehouse/docs

Conversation

@atravitz

@atravitz atravitz commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

No API break detected ✅

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (7ec596b) to head (6ebdebb).

Additional details and impacted files
@@                Coverage Diff                 @@
##           feat/warehouse    #1988      +/-   ##
==================================================
+ Coverage           90.33%   90.34%   +0.01%     
==================================================
  Files                 212      212              
  Lines               20086    20092       +6     
==================================================
+ Hits                18144    18152       +8     
+ Misses               1942     1940       -2     
Flag Coverage Δ
fast-tests 90.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz changed the base branch from main to feat/warehouse June 5, 2026 21:46
Parameters
----------
setup : ExternalStorage
setup : RequiredExternalStorage

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know Required is the default, but can we be explicit here for the sake of documentation?

Also, do we want to actually validate this? Otherwise it won't fail until there's a key error when someone tries to access .result_store.

Comment on lines 19 to 20
def test_store_protocol_dag_result(self):
pytest.skip("Not implemented yet")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the plan for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant