Skip to content

[WIP] CLI: refactor to use QuickrunResult dataclass#1789

Draft
atravitz wants to merge 15 commits into
mainfrom
cli/refactor_quickrun_result
Draft

[WIP] CLI: refactor to use QuickrunResult dataclass#1789
atravitz wants to merge 15 commits into
mainfrom
cli/refactor_quickrun_result

Conversation

@atravitz

@atravitz atravitz commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Trying this out to see if it helps us handle septop and abfe results gathering, plus setting us up to more clearly defined a ResultsNetwork object.

Includes breaking changes to quickrun reading/writing, so WIP.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@codecov

codecov Bot commented Jan 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.59%. Comparing base (58d1e00) to head (96b4068).

Files with missing lines Patch % Lines
src/openfecli/quickrun_result.py 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
- Coverage   94.96%   90.59%   -4.37%     
==========================================
  Files         217      218       +1     
  Lines       20725    20752      +27     
==========================================
- Hits        19681    18801     -880     
- Misses       1044     1951     +907     
Flag Coverage Δ
fast-tests 90.59% <96.87%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz self-assigned this Mar 20, 2026
@github-actions

Copy link
Copy Markdown

No API break detected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant