Skip to content

transformations - use parent class init#798

Merged
atravitz merged 2 commits into
mainfrom
maint/clean_up_transformation
Jun 22, 2026
Merged

transformations - use parent class init#798
atravitz merged 2 commits into
mainfrom
maint/clean_up_transformation

Conversation

@atravitz

@atravitz atravitz commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

I noticed missing codecov here. Initializing using the parent class will cover this, and avoid strange diverging behavior in the future.

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci atomically format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Checklist

  • Added a news entry

Developers certificate of origin

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (480d77c) to head (a493bb1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   98.54%   98.64%   +0.10%     
==========================================
  Files          43       43              
  Lines        2811     2807       -4     
==========================================
- Hits         2770     2769       -1     
+ Misses         41       38       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz requested a review from ianmkenney June 17, 2026 17:26
@atravitz atravitz marked this pull request as ready for review June 17, 2026 17:26

@ianmkenney ianmkenney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, not sure why I didn't do this in the original. Only nitpick would be to put the super().init calls at the top of the function.

@atravitz atravitz force-pushed the maint/clean_up_transformation branch from 90f1328 to a493bb1 Compare June 22, 2026 21:26
@atravitz atravitz added this to the v1.12.0 milestone Jun 22, 2026
@atravitz atravitz enabled auto-merge (squash) June 22, 2026 21:39
@github-actions

Copy link
Copy Markdown

🚨 API breaking changes detected! 🚨
View logs for this step

@atravitz atravitz merged commit b7d5714 into main Jun 22, 2026
16 checks passed
@atravitz atravitz deleted the maint/clean_up_transformation branch June 22, 2026 22:20
@mikemhenry mikemhenry mentioned this pull request Jun 23, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants