Skip to content

[WIP] fixes for pydantic>2.12#794

Draft
atravitz wants to merge 3 commits into
mainfrom
fix/pydantic_v2.12
Draft

[WIP] fixes for pydantic>2.12#794
atravitz wants to merge 3 commits into
mainfrom
fix/pydantic_v2.12

Conversation

@atravitz

@atravitz atravitz commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

following @mattwthompson's lead at: https://github.com/openforcefield/openff-interchange/pull/1501/changes

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci atomically format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Checklist

  • Added a news entry

Developers certificate of origin

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

No API break detected ✅

@mattwthompson

Copy link
Copy Markdown
Contributor

I'm not sure why the serialized representation changes - whether or not the default value of "nonbonded_cutoff" is serialized might not be important, but I've seen problems1 in which a serialized non-default value is ignored and set to the default value2.

The failures due to dependencies not being installed is just from the switch to the Conda package to the development install - cachetools, python-constraint, and xmltodict are probably all you need

Footnotes

  1. https://github.com/openforcefield/openff-interchange/pull/1501#issuecomment-4545442911

  2. Bad!

@atravitz atravitz changed the title fixes for pydantic>2.12 [WIP] fixes for pydantic>2.12 Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants