Warehouse/fix shared storage#780
Draft
atravitz wants to merge 1 commit into
Draft
Conversation
atravitz
force-pushed
the
warehouse/fix_shared_storage
branch
from
9d95e92 to
41d3bc4
Compare
atravitz
force-pushed
the
warehouse/fix_shared_storage
branch
from
41d3bc4 to
9fa5c34
Compare
atravitz
force-pushed
the
warehouse/fix_shared_storage
branch
from
9fa5c34 to
8cca059
Compare
|
🚨 API breaking changes detected! 🚨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the file existence check here wasn't actually checking for deletion of the file store.
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Checklist
newsentryDevelopers certificate of origin