fixes issue #274#282
Open
richardjgowers wants to merge 2 commits into
Open
Conversation
adds optional ChemicalSystem arguments to default_settings. these can optionally be used to allow the default settings of a Protocol to adapt to the chemistry that will be encountered
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 98.98% 98.93% -0.05%
==========================================
Files 36 36
Lines 1966 1969 +3
==========================================
+ Hits 1946 1948 +2
- Misses 20 21 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds optional ChemicalSystem arguments to default_settings.
these can optionally be used to allow the default settings of a Protocol to adapt to the chemistry that will be encountered