Add custom estimator docs#225
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 22 22
Lines 2470 2470
=======================================
Hits 2409 2409
Misses 61 61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,404 @@ | |||
| { | |||
There was a problem hiding this comment.
[nit] After the second sentence, it might be good to put something like "Here we demonstrate how you can do this." It's really obvious, but it might help with reading comprehension.
Reply via ReviewNB
| @@ -0,0 +1,404 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,404 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #72. sign = 1.0 if graph.has_edge(label_a, label_b) else -1.0
Can you have direction in the edge if you have an undirected graph (i.e. you're using nx.Graph above)?
Reply via ReviewNB
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
I'm going to very lightly block on the graph direction bit, just because it's a bit confusing to readers. Everything else looks great though!
2 participants
Description
Provide a brief description of the PR's purpose here.
Drafted by me and cleaned with GPT5
Fixes #210
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Checklist
newsentry for new features, bug fixes, or other user facing changes.Status
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.