Android App #251
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| # Using Android gitignore template: https://github.com/github/gitignore/blob/HEAD/Android.gitignore | ||
|
|
||
| # Built application files | ||
| *.apk | ||
| *.aar | ||
| *.ap_ | ||
| *.aab | ||
|
|
||
| # Files for the ART/Dalvik VM | ||
| *.dex | ||
|
|
||
| # Java class files | ||
| *.class | ||
|
|
||
| # Generated files | ||
| bin/ | ||
| gen/ | ||
| out/ | ||
| # Uncomment the following line in case you need and you don't have the release build type files in your app | ||
| # release/ | ||
|
|
||
| # Gradle files | ||
| .gradle/ | ||
| build/ | ||
|
|
||
| # Local configuration file (sdk path, etc) | ||
| local.properties | ||
|
|
||
| # Proguard folder generated by Eclipse | ||
| proguard/ | ||
|
|
||
| # Log Files | ||
| *.log | ||
|
|
||
| # Android Studio Navigation editor temp files | ||
| .navigation/ | ||
|
|
||
| # Android Studio captures folder | ||
| captures/ | ||
|
|
||
| # IntelliJ | ||
| *.iml | ||
| .idea/workspace.xml | ||
| .idea/tasks.xml | ||
| .idea/gradle.xml | ||
| .idea/assetWizardSettings.xml | ||
| .idea/dictionaries | ||
| .idea/libraries | ||
| # Android Studio 3 in .gitignore file. | ||
| .idea/caches | ||
| .idea/modules.xml | ||
| # Comment next line if keeping position of elements in Navigation Editor is relevant for you | ||
| .idea/navEditor.xml | ||
|
|
||
| # Keystore files | ||
| # Uncomment the following lines if you do not want to check your keystore files in. | ||
| #*.jks | ||
| #*.keystore | ||
|
|
||
| # External native build folder generated in Android Studio 2.2 and later | ||
| .externalNativeBuild | ||
| .cxx/ | ||
|
|
||
| # Google Services (e.g. APIs or Firebase) | ||
| # google-services.json | ||
|
|
||
| # Freeline | ||
| freeline.py | ||
| freeline/ | ||
| freeline_project_description.json | ||
|
|
||
| # fastlane | ||
| fastlane/report.xml | ||
| fastlane/Preview.html | ||
| fastlane/screenshots | ||
| fastlane/test_output | ||
| fastlane/readme.md | ||
|
|
||
| # Version control | ||
| vcs.xml | ||
|
|
||
| # lint | ||
| lint/intermediates/ | ||
| lint/generated/ | ||
| lint/outputs/ | ||
| lint/tmp/ | ||
| # lint/reports/ | ||
|
|
||
| # Android Profiling | ||
| *.hprof | ||
|
|
||
| # Cordova plugins for Capacitor | ||
| capacitor-cordova-android-plugins | ||
|
|
||
| # Copied web assets | ||
| app/src/main/assets/public | ||
|
|
||
| # Generated Config files | ||
| app/src/main/assets/capacitor.config.json | ||
| app/src/main/assets/capacitor.plugins.json | ||
| app/src/main/res/xml/config.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /build/* | ||
| !/build/.npmkeep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| apply plugin: 'com.android.application' | ||
|
|
||
| android { | ||
| namespace = "com.opencloudgaming.opennow" | ||
| compileSdk = rootProject.ext.compileSdkVersion | ||
| defaultConfig { | ||
| applicationId "com.opencloudgaming.opennow" | ||
| minSdkVersion rootProject.ext.minSdkVersion | ||
| targetSdkVersion rootProject.ext.targetSdkVersion | ||
| versionCode 1 | ||
|
Contributor
There was a problem hiding this comment. [🟡 Medium] [🔵 Bug] The new Android target hard-codes its install metadata instead of following the project version that the existing release workflow already updates in |
||
| versionName "1.0" | ||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | ||
| aaptOptions { | ||
| // Files and dirs to omit from the packaged assets dir, modified to accommodate modern web apps. | ||
| // Default: https://android.googlesource.com/platform/frameworks/base/+/282e181b58cf72b6ca770dc7ca5f91f135444502/tools/aapt/AaptAssets.cpp#61 | ||
| ignoreAssetsPattern = '!.svn:!.git:!.ds_store:!*.scc:.*:!CVS:!thumbs.db:!picasa.ini:!*~' | ||
| } | ||
| } | ||
| buildTypes { | ||
| release { | ||
| minifyEnabled false | ||
| proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' | ||
| } | ||
| } | ||
| } | ||
|
|
||
| repositories { | ||
| flatDir{ | ||
| dirs '../capacitor-cordova-android-plugins/src/main/libs', 'libs' | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation fileTree(include: ['*.jar'], dir: 'libs') | ||
| implementation "androidx.appcompat:appcompat:$androidxAppCompatVersion" | ||
| implementation "androidx.coordinatorlayout:coordinatorlayout:$androidxCoordinatorLayoutVersion" | ||
| implementation "androidx.core:core-splashscreen:$coreSplashScreenVersion" | ||
| implementation project(':capacitor-android') | ||
| testImplementation "junit:junit:$junitVersion" | ||
| androidTestImplementation "androidx.test.ext:junit:$androidxJunitVersion" | ||
| androidTestImplementation "androidx.test.espresso:espresso-core:$androidxEspressoCoreVersion" | ||
| implementation project(':capacitor-cordova-android-plugins') | ||
| } | ||
|
|
||
| apply from: 'capacitor.build.gradle' | ||
|
|
||
| try { | ||
| def servicesJSON = file('google-services.json') | ||
| if (servicesJSON.text) { | ||
| apply plugin: 'com.google.gms.google-services' | ||
| } | ||
| } catch(Exception e) { | ||
| logger.info("google-services.json not found, google-services plugin not applied. Push Notifications won't work") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // DO NOT EDIT THIS FILE! IT IS GENERATED EACH TIME "capacitor update" IS RUN | ||
|
|
||
| android { | ||
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_21 | ||
| targetCompatibility JavaVersion.VERSION_21 | ||
| } | ||
| } | ||
|
|
||
| apply from: "../capacitor-cordova-android-plugins/cordova.variables.gradle" | ||
| dependencies { | ||
| implementation project(':capacitor-app') | ||
| implementation project(':capacitor-browser') | ||
| implementation project(':capacitor-device') | ||
| implementation project(':capacitor-filesystem') | ||
| implementation project(':capacitor-preferences') | ||
| implementation project(':capacitor-status-bar') | ||
|
|
||
| } | ||
|
|
||
|
|
||
| if (hasProperty('postBuildExtras')) { | ||
| postBuildExtras() | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[🟡 Medium] [🟡 Investigate]
android-actions/setup-androidonly installs the command-line tools andplatform-toolsby default, but this PR pins the Android project to API 36 in @opennow-stable/android/variables.gradle. That means the new job is only green as long as the hosted Ubuntu image happens to prebundle the required SDK platform/build-tools; on a fresh or rotated runner,./gradlew assembleDebugwill fail before compilation with a missingandroid-36/build-tools error. Explicitly installing the platform (and matching build-tools) in the workflow makes the Android build reproducible.