Skip to content

fix: normalize OAS 3.1 schemas with type:[object,"null"] to set nullable:true correctly#24140

Draft
Picazsoo wants to merge 10 commits into
OpenAPITools:masterfrom
Picazsoo:bugfix/fix-nullable-open-api-3.1
Draft

fix: normalize OAS 3.1 schemas with type:[object,"null"] to set nullable:true correctly#24140
Picazsoo wants to merge 10 commits into
OpenAPITools:masterfrom
Picazsoo:bugfix/fix-nullable-open-api-3.1

Conversation

@Picazsoo

@Picazsoo Picazsoo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Reverts the OAS 3.1 normalization that converted type: [object, "null"] (and other type arrays including "null") into nullable: true, restoring prior behavior. Backs out the fix related to issue 24139 for further review.

Written for commit f741e48. Summary will update on new commits.

Review in cubic

Picazsoo added 4 commits June 26, 2026 17:57
…set nullable:true correctly and preserve properties"

This reverts commit cb5aa49.
… set nullable:true correctly and preserve properties"

This reverts commit b0d188d.
Picazsoo and others added 6 commits June 27, 2026 14:55
…g "null" set nullable:true correctly and preserve properties""

This reverts commit 74eb333.
… set nullable:true correctly and preserve properties"

This reverts commit b0d188d.
…set nullable:true correctly and preserve properties"

This reverts commit cb5aa49.
…et nullable:true correctly"

This reverts commit 29c6207.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant