Fix #1539: Change ObaStudyRequest.Builder.mUri to an instance field#1542
Open
Gitkbc wants to merge 1 commit into
Open
Fix #1539: Change ObaStudyRequest.Builder.mUri to an instance field#1542Gitkbc wants to merge 1 commit into
Gitkbc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
URIfield inObaStudyRequest.Builderwas declared asstatic.Because it was static, the URI was shared across all Builder instances. This could cause a "stale data" issue where a new request might accidentally reuse the URI from a previous successful call if a subsequent initialization failed.
I've changed this to an instance field
mUrias suggested in the description of the #1539 issue to ensure each Builder maintains its own state.