Skip to content

fix: add forge version check to check-build.sh #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tenderdeve wants to merge 3 commits into
base: master
Choose a base branch
from
+21 −4
Open

fix: add forge version check to check-build.sh #4677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1678f7
fix: add forge version check to check-build.sh
tenderdeve Apr 28, 2026
a3cd404
Update scripts/check-build.sh
tenderdeve May 7, 2026
e2c3993
fix(check-build): collapse foundry/forge checks and add changelog
tenderdeve May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog/tenderdeve-nit-4379.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
### Internal
- Validate forge version (1.0.0) in `scripts/check-build.sh` and emit a clear remediation message when an incompatible version is installed
23 changes: 19 additions & 4 deletions scripts/check-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ NC='\033[0m' # No Color
node_version_needed="v24"
rust_version_needed="1.93.0"
golangci_lint_version_needed="2.5.0"
forge_version_needed="1.0.0"

if [[ -f go.mod ]]; then
go_version_needed=$(grep "^go " go.mod | awk '{print $2}')
Expand Down Expand Up @@ -187,12 +188,26 @@ else
EXIT_CODE=1
fi

# Check Foundry installation
if command_exists foundryup; then
echo -e "${GREEN}Foundry is installed.${NC}"
else
# Check Foundry / forge installation and version compatibility
# Newer forge versions (> 1.0.0) use solar instead of solc for Yul compilation,
# which causes `make build` to fail.
if ! command_exists foundryup; then
echo -e "${RED}Foundry is not installed.${NC}"
EXIT_CODE=1
elif ! command_exists forge; then
echo -e "${RED}forge is not installed. Run: foundryup --version $forge_version_needed${NC}"
EXIT_CODE=1
else
FORGE_INSTALLED_VERSION=$(forge --version 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -n 1)
if [[ -z "$FORGE_INSTALLED_VERSION" ]]; then
echo -e "${RED}Could not parse forge version from \`forge --version\`.${NC}"
EXIT_CODE=1
elif compare_versions "$forge_version_needed" "$FORGE_INSTALLED_VERSION" "exact"; then
echo -e "${GREEN}forge version $FORGE_INSTALLED_VERSION is installed.${NC}"
else
echo -e "${RED}forge version $FORGE_INSTALLED_VERSION is not compatible. Version $forge_version_needed is required (newer versions use solar instead of solc for Yul compilation). Run: foundryup --version $forge_version_needed${NC}"
EXIT_CODE=1
fi
fi

if [ $EXIT_CODE != 0 ]; then
Expand Down
Loading