contributing: Use SPDX copyright tags in more complicated file headers - #7751
Open
wenzeslaus wants to merge 1 commit into
Open
contributing: Use SPDX copyright tags in more complicated file headers#7751wenzeslaus wants to merge 1 commit into
wenzeslaus wants to merge 1 commit into
Conversation
Convert the 31 files the bulk conversion left alone because their notices needed reading rather than pattern matching. Names and years stay verbatim; each holder gets its own line; the collective line and the license identifier follow the same rules as everywhere else. Notices naming several people are split into one line per person, with a shared year range repeated on each line: v.vol.rst (five holders), r.stats.zonal, r.tileset, and r.out.xyz, whose two clauses carry their own years. Organization names with punctuation stay on one line: mundialis GmbH & Co.KG, University of Sannio (BN), Benevento, Italy, and GDF Hannover bR with its URL. Text interleaved with the old notices survives unchanged: the NOTE in open_misc.c, the modification history in v.perturb, the port note in r3.in.xyz, the third-party permission notice in r.texture, and the RMIT license text in v.delaunay. Two decisions go beyond the bulk conversion rules and were made by the maintainer. The geomorphon clause on the scientific idea is dropped: it was likely meant as an acknowledgement of the authors of the geomorphon concept rather than as a record of a legal right, and that acknowledgement is given by the tool documentation, which cites their papers and lists them as authors. The three imagery tools whose prose named an unversioned GNU Lesser General Public License while pointing at the GPL COPYING file are converted to GPL-2.0-or-later, following the COPYING reference. In v.delaunay, the RMIT clause becomes "1993 RMIT" and the team clause becomes the standard bare collective line, so its 2008-2009 years are not carried over. The edits were applied by a small script with one reviewed replacement per file, written with AI assistance (Claude Opus 4.8); the decisions are the author's.
neteler
approved these changes
Jul 17, 2026
neteler
left a comment
Member
There was a problem hiding this comment.
I have scanned it, looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the 31 files that #7743 left out because their notices needed reading rather than pattern matching.
mundialis GmbH & Co.KG,GDF Hannover bR, http://www.gdf-hannover.de).The largest split,
vector/v.vol.rst:Two decisions here go beyond the mechanical rules of #7743:
(C) Scientific idea of geomorphon copyrighted to authors.is dropped. It was likely meant as an acknowledgement of the authors of the geomorphon concept rather than as a record of a legal right, and that acknowledgement is given by the tool documentation, which cites their papers and lists them as authors.COPYINGfile are converted toGPL-2.0-or-later, following theCOPYINGreference.Like #7743, this should technically merge after #7749, which defines "Other GRASS authors", but it does not have to.
Written with AI assistance (Claude Code with Opus 4.8 and Fable 5); the decisions are the author's.
Details: per-file resolutions and how it was checked (AI generated)
Splits into one line per holder
vector/v.vol.rst/*(8 files): five holders, shared years1989, 1993, 2000repeated on each line.raster/r.stats.zonal/main.c:2007,2008 Martin Schroederand2007,2008 Glynn Clements.scripts/r.tileset/r.tileset.py:2006-2009 Cedric Shocand2006-2009 Martin Landa, spelling as written.scripts/r.out.xyz/r.out.xyz.py: two clauses, each with its own year,2006 Hamish Bowmanand2008 Glynn Clements.Single holders whose names carry punctuation
2019 mundialis GmbH & Co.KG(two files),2003 University of Sannio (BN), Benevento, Italy, and2004, 2005 GDF Hannover bR, http://www.gdf-hannover.de, each on one line exactly as written.Interleaved text kept in place
The
NOTEinlib/gis/open_misc.c, the modification history invector/v.perturb/main.c, the port note inscripts/r3.in.xyz/r3.in.xyz.py, the attribution paragraph inmacos/build_grass_app.bash, the third-party permission notice below the header inraster/r.texture/main.c, and the RMIT license text invector/v.delaunay/main.care all byte-identical to before.v.delaunay (8 files)
(C) RMIT 1993becomesSPDX-FileCopyrightText: 1993 RMIT, years first like every other line in the tree. The team clause becomes the standard bare collective line, so its2008-2009years are not carried over; this is the one place in this PR where years from the old notice are not preserved.Checked
Each of the 31 files was changed by a single reviewed replacement applied by a small script that asserts the old text occurs exactly once, the trailing bytes are unchanged, no
COPYRIGHT:field remains, and exactly one license identifier results. No emitted C line exceeds 78 columns, andpre-commit runon all 31 files passes with nothing reformatted.lib/vector/rtree/docs/MAILS, an archived 2002 email that quotes a header inside a permission request, remains excluded and untouched.