Conversation
| FROM bitnamilegacy/minio:$VERSION as minio-docker | ||
| FROM docker.io/bitnami/minideb:bookworm |
There was a problem hiding this comment.
Why does this have 2 FROM directives and why build this image? Is there something wrong with the upstream image?
There was a problem hiding this comment.
I see the commit message of why this exists, so the two FROM is strange but also if the deployment labels are well known, you could exclude here:
Maybe add minio to the list if that label matches? Then just bump patch release on that kyverno-policies chart.
There was a problem hiding this comment.
I think the two FROM directives were probably a copying error, but it was 4 months ago so I'm not sure. So if I add minio to that list it will make an exception for minio and allow me to use the upstream image?
There was a problem hiding this comment.
Correct, I'd recommend make the Kyverno change in a new PR or I can make it if you let me know , so you can validate before this larger PR is merged.
| FROM bitnamilegacy/minio:$VERSION as minio-docker | ||
| FROM docker.io/bitnami/minideb:bookworm |
There was a problem hiding this comment.
I see the commit message of why this exists, so the two FROM is strange but also if the deployment labels are well known, you could exclude here:
Maybe add minio to the list if that label matches? Then just bump patch release on that kyverno-policies chart.
Co-authored-by: treydock <tdockendorf@osc.edu>
Co-authored-by: treydock <tdockendorf@osc.edu>
Co-authored-by: treydock <tdockendorf@osc.edu>
Co-authored-by: treydock <tdockendorf@osc.edu>
| value: | ||
| - prometheus | ||
| - postgresql | ||
| - minio |
There was a problem hiding this comment.
I can do this, I have to push another minor change
| description: OSC Kyverno policies deployment | ||
| type: application | ||
| version: 0.38.3 | ||
| version: 0.38.4 |
There was a problem hiding this comment.
Move this into new PR so you can test with oscchat-test namespace. I'll get that merged before this bigger PR.
There was a problem hiding this comment.
I can do this, I have to push another minor change
This reverts commit 8c9bcef.
Co-authored-by: treydock <tdockendorf@osc.edu>
2 participants
No description provided.