[main] fix keytip shortcut persistence between ribbon tab switches - #3213
Open
pedrocovisi wants to merge 1 commit into
Open
[main] fix keytip shortcut persistence between ribbon tab switches#3213pedrocovisi wants to merge 1 commit into
pedrocovisi wants to merge 1 commit into
Conversation
When switching between ribbon tabs using Alt shortcuts (e.g. Alt+N then Alt+H), dynamically assigned data-hint-title-lang attributes from the previous tab visit persisted. This caused HintManager to incorrectly assume all visible items already had keytip titles assigned and skip reassignment, resulting in shortened single-letter shortcuts (such as 'A' instead of 'AA' for the format painter). This commit removes dynamically assigned data-hint-title-lang attributes when recounting items before the length check, ensuring correct multi-letter keytips are generated when switching tabs.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching between ribbon tabs using Alt shortcuts (e.g. Alt+N then Alt+H), dynamically assigned data-hint-title-lang attributes from the previous tab visit persisted. This caused HintManager to incorrectly assume all visible items already had keytip titles assigned and skip reassignment, resulting in shortened single-letter shortcuts (such as 'A' instead of 'AA' for the format painter).
This commit removes dynamically assigned data-hint-title-lang attributes when recounting items before the length check, ensuring correct multi-letter keytips are generated when switching tabs.