Skip to content

feat: Add nifti and dicom example segmentations#11

Open
wayfarer3130 wants to merge 4 commits into
masterfrom
feat/add-juno-example-segmentations
Open

feat: Add nifti and dicom example segmentations#11
wayfarer3130 wants to merge 4 commits into
masterfrom
feat/add-juno-example-segmentations

Conversation

@wayfarer3130

Copy link
Copy Markdown
Contributor

Adds example segmentations to use for testing OHIF with segmentations - both nifti and dicom

@wayfarer3130 wayfarer3130 requested a review from sedghi May 21, 2026 18:30
@wayfarer3130

Copy link
Copy Markdown
Contributor Author

@sedghi - these are all created segmentations so should be safe to merge. If you want Joe to review instead, he can be added as a writer to this repo - I think I can do that.

@sedghi sedghi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add data citation to this repo as well. where is data sourced from. something like this, viewer-testdata is missing it

https://github.com/OHIF/Viewers/blob/master/DATACITATION.md

@wayfarer3130

Copy link
Copy Markdown
Contributor Author

can we add data citation to this repo as well. where is data sourced from. something like this, viewer-testdata is missing it

https://github.com/OHIF/Viewers/blob/master/DATACITATION.md

Mostly I don't know where the data is sourced from - I don't mind adding it for data I source myself, but the segmentations are all derived data, so aren't the primary citation. Doesn't feel like it really belongs in this PR. I will start creating a second PR trying to get source citations if I can.

@sedghi

sedghi commented May 22, 2026

Copy link
Copy Markdown
Member

We shouldn't use data if we don't know its licensing. Some of it might require us to give credit, and certain algorithms can also require citations even if they are free.

@fedorov

fedorov commented May 22, 2026

Copy link
Copy Markdown
Member

Thank you for documenting the sources of data and including the proper acknowledgments in https://github.com/OHIF/Viewers/blob/master/DATACITATION.md!

One thing missing from that page (and that I would strongly encourage you to add) is the statement about licensing applied to the data. For the studies that come from IDC, I used IDC skill to get the licensing information (given StudyInstanceUIDs listed), and almost all of the studies you included are available under CC-BY. With one exception: I would recommend you exclude NSCLC-Radiomics content from your test data, since it does not allow commercial use (see https://www.cancerimagingarchive.net/collection/nsclc-radiomics/).

@wayfarer3130

Copy link
Copy Markdown
Contributor Author

@fedorov - I updated it with the license information. Will merge it if it looks ok to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants