feat: Add nifti and dicom example segmentations#11
Conversation
|
@sedghi - these are all created segmentations so should be safe to merge. If you want Joe to review instead, he can be added as a writer to this repo - I think I can do that. |
sedghi
left a comment
There was a problem hiding this comment.
can we add data citation to this repo as well. where is data sourced from. something like this, viewer-testdata is missing it
Mostly I don't know where the data is sourced from - I don't mind adding it for data I source myself, but the segmentations are all derived data, so aren't the primary citation. Doesn't feel like it really belongs in this PR. I will start creating a second PR trying to get source citations if I can. |
|
We shouldn't use data if we don't know its licensing. Some of it might require us to give credit, and certain algorithms can also require citations even if they are free. |
|
Thank you for documenting the sources of data and including the proper acknowledgments in https://github.com/OHIF/Viewers/blob/master/DATACITATION.md! One thing missing from that page (and that I would strongly encourage you to add) is the statement about licensing applied to the data. For the studies that come from IDC, I used IDC skill to get the licensing information (given |
|
@fedorov - I updated it with the license information. Will merge it if it looks ok to you. |
Adds example segmentations to use for testing OHIF with segmentations - both nifti and dicom