Fix database credential dialog defaults (#3231) - #3248
Open
SantanM wants to merge 1 commit into
Open
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: SantanM <55120902+SantanM@users.noreply.github.com> (cherry picked from commit cd3b9de)
SantanM
requested review from
hengxian-jiang,
p-hoffmann and
suwarnoong
as code owners
August 31, 2026 06:51
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the credential dialog when the database API omits authentication mode.
Changes:
- Defaults database authentication to Password.
- Removes obsolete JWT support.
- Aligns response types with the API contract.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
dbCredentials.ts |
Removes JWT and obsolete response field. |
EditDbCredentialsDialog.tsx |
Initializes Password mode and standardizes dialog width. |
db-credentials-mgr.ts |
Maps database responses to Password authentication. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hengxian-jiang
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit cd3b9de)
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)