Skip to content

fix(wizards): use materialized cohort id response - #3198

Merged
jerome-ng merged 3 commits into
developfrom
jerome-ng/fix-wizards-materialization-id-develop
Sep 1, 2026
Merged

fix(wizards): use materialized cohort id response#3198
jerome-ng merged 3 commits into
developfrom
jerome-ng/fix-wizards-materialization-id-develop

Conversation

@jerome-ng

@jerome-ng jerome-ng commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • consume and validate cohortDefinitionId from the cohort materialization response
  • open the Wizard dashboard without waiting for bookmark-list visibility
  • keep bookmark cache refresh best-effort and remove the obsolete resolving-cohort state
  • collapse cache lookup and automated bookmark saving into one applying-filters state with neutral Applying filters... copy
  • update wizard loading stages to remove unneccessary mesages

Previous:
Screenshot 2026-08-28 at 10 02 00 AM

Updated:
Codex Image 28 Aug 2026, 10_54_39

Verification

  • bun run test (18 files, 185 tests passed)
  • bun run build
  • targeted Prettier check for all touched files
  • ESLint completed with two pre-existing warnings
  • browser-verified unified Applying filters... messaging across delayed cache lookup and bookmark saving; previous messages absent

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Wizard dashboard flow to use the cohort ID returned by materialization instead of waiting for bookmark-list propagation.

Changes:

  • Validates and consumes the materialization response.
  • Refreshes the bookmark cache asynchronously.
  • Removes the obsolete cohort-resolution stage and related retry state.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
wizardDashboardState.ts Removes the resolution status.
wizardDashboardFlow.ts Uses the returned cohort ID and refreshes asynchronously.
wizardDashboardFlow.test.ts Updates flow tests for the new behavior.
useWizardDashboardFlow.ts Removes materialization-submission tracking.
WizardDashboardModal.tsx Removes the obsolete progress message.
wizardCohortApi.ts Adds the materialization response contract and validation.
wizardCohortApi.test.ts Tests returned and missing cohort IDs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread plugins/ui/apps/wizards/src/api/wizardCohortApi.ts
Comment thread plugins/ui/apps/wizards/src/services/wizardDashboardFlow.ts
"awaiting-cache": "Checking your previous Wizard analyses…",
"saving-bookmark": "Saving this Wizard analysis…",
materializing: "Creating the cohort…",
"resolving-cohort": "Waiting for the cohort to become available…",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed

@jerome-ng
jerome-ng enabled auto-merge August 28, 2026 03:20
@jerome-ng
jerome-ng added this pull request to the merge queue Aug 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 28, 2026
@jerome-ng
jerome-ng added this pull request to the merge queue Aug 31, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 31, 2026
@jerome-ng
jerome-ng added this pull request to the merge queue Aug 31, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 31, 2026
@jerome-ng
jerome-ng added this pull request to the merge queue Sep 1, 2026
Merged via the queue into develop with commit 7d2d686 Sep 1, 2026
69 of 70 checks passed
@jerome-ng
jerome-ng deleted the jerome-ng/fix-wizards-materialization-id-develop branch September 1, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants