[Data - 3127] Add tag to cohort definitions - #3173
Merged
Zhimin-arya merged 23 commits intoSep 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds provenance and review-status tags to imported Phenotype Library cohorts.
Changes:
- Seeds tag groups and implements tag creation/assignment.
- Makes cohort imports update existing definitions.
- Disables caching for MIMIC conversion tasks and broadens tag DTO compatibility.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
services/atlas-db-init/220_imported_cohort_metadata_tag_group.sql |
Seeds cohort tag groups. |
plugins/functions/d2e-webapi/src/dto/cohortdefinition.ts |
Accepts nullable WebAPI tag metadata. |
plugins/flows/data_transformation/mimic_omop_conversion_plugin/omop_conversion.py |
Disables task caching. |
plugins/flows/data_transformation/mimic_omop_conversion_plugin/load_data.py |
Disables loading-task caching. |
plugins/flows/base/phenotype_plugin/get_cohort_definitions.R |
Retrieves and returns review statuses. |
plugins/flows/base/phenotype_plugin/flow.py |
Upserts and tags imported cohorts. |
plugins/flows/_shared_flow_utils/api/PhenotypeTagAPI.py |
Adds WebAPI tag operations. |
plugins/flows/_shared_flow_utils/api/PhenotypeAPI.py |
Adds name-based cohort updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (921 %in% cohortsID) { | ||
| cohortsID <- cohortsID[cohortsID!=921] | ||
| } | ||
| cohortDefinitionSets <- PhenotypeLibrary::getPlCohortDefinitionSet(cohortsID) |
Comment on lines
+112
to
+114
| for name, group in wanted: | ||
| if name.lower() not in by_name: | ||
| by_name[name.lower()] = self._create_tag(dataset_id, name, group["id"]) |
alicia-koh
approved these changes
Aug 25, 2026
brandantck
reviewed
Aug 26, 2026
brandantck
approved these changes
Aug 26, 2026
…ttps://github.com/OHDSI/Data2Evidence into Zhimin-arya/data-3127_add-tag-to-cohort-definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Phenotype Library,${status})Result:
webapi.cohort_tagwebapi.tagMerge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)