chore: refactor#586
Merged
OGKevin merged 3 commits intoJun 11, 2026
Merged
Conversation
OGKevin
force-pushed
the
copilot/ogkevinpushqvslmuwsvkks
branch
from
June 10, 2026 10:07
7bc8b89 to
548ae9f
Compare
OGKevin
temporarily deployed
to
cloudflare-pages-preview
June 10, 2026 10:10 — with
GitHub Actions
Inactive
OGKevin
force-pushed
the
copilot/ogkevinpushqvslmuwsvkks
branch
from
June 11, 2026 06:49
548ae9f to
8e30a85
Compare
OGKevin
temporarily deployed
to
cloudflare-pages-preview
June 11, 2026 06:52 — with
GitHub Actions
Inactive
Cargo build scripts for registry crates (like libsqlite3-sys) run with
the crate's registry source directory as their working directory, not the
workspace root. When SQLITE3_INCLUDE_DIR is set to a relative path,
bindgen passes that path to libclang which resolves it relative to the
build script's CWD — where the file does not exist — causing the panic:
could not run bindgen on header target/cadmus-build-deps/…/sqlite3.h
Fix: use ${{ github.workspace }} in the workflow and $DEVENV_ROOT in
devenv.nix to make both paths absolute at runtime.
Co-authored-by: OGKevin <17928966+OGKevin@users.noreply.github.com>
OGKevin
force-pushed
the
ogkevin/push/qvslmuwsvkks
branch
from
June 11, 2026 07:43
8b3b923 to
1ee72a5
Compare
OGKevin
force-pushed
the
copilot/ogkevinpushqvslmuwsvkks
branch
from
June 11, 2026 07:43
8e30a85 to
6e3df5f
Compare
OGKevin
temporarily deployed
to
cloudflare-pages-preview
June 11, 2026 07:52 — with
GitHub Actions
Inactive
OGKevin
force-pushed
the
copilot/ogkevinpushqvslmuwsvkks
branch
from
June 11, 2026 08:23
6e3df5f to
344da0b
Compare
OGKevin
temporarily deployed
to
cloudflare-pages-preview
June 11, 2026 08:27 — with
GitHub Actions
Inactive
OGKevin
force-pushed
the
copilot/ogkevinpushqvslmuwsvkks
branch
from
June 11, 2026 08:56
344da0b to
eeb2fe4
Compare
OGKevin
temporarily deployed
to
cloudflare-pages-preview
June 11, 2026 09:00 — with
GitHub Actions
Inactive
OGKevin
force-pushed
the
copilot/ogkevinpushqvslmuwsvkks
branch
from
June 11, 2026 09:43
eeb2fe4 to
43454f1
Compare
Change-Id: 8cc25f3dbefa02393f87d1de13859b99 Change-Id-Short: rnnxukwmolkp
OGKevin
had a problem deploying
to
cloudflare-pages-preview
June 11, 2026 09:46 — with
GitHub Actions
Error
OGKevin
force-pushed
the
copilot/ogkevinpushqvslmuwsvkks
branch
from
June 11, 2026 09:46
43454f1 to
6b610b6
Compare
OGKevin
marked this pull request as ready for review
June 11, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #585. I've created this new PR, which merges into #585, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.
Original PR: #585
Triggering comment (#585 (comment)):