Skip to content

chore: refactor#586

Merged
OGKevin merged 3 commits into
ogkevin/push/qvslmuwsvkksfrom
copilot/ogkevinpushqvslmuwsvkks
Jun 11, 2026
Merged

chore: refactor#586
OGKevin merged 3 commits into
ogkevin/push/qvslmuwsvkksfrom
copilot/ogkevinpushqvslmuwsvkks

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #585. I've created this new PR, which merges into #585, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #585
Triggering comment (#585 (comment)):

@copilot can you reproduce this failure in your environment and open a new PR with your proposed fix to resolve the CI failure. I can't spot the diff in devenv.nix on MacOS and therefore not sure what the issue is.

error: failed to run custom build command for `libsqlite3-sys v0.30.1`

Caused by:
  process didn't exit successfully: `/home/runner/work/cadmus/cadmus/target/debug/build/libsqlite3-sys-b988ea1e2e988e87/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=LIBSQLITE3_SYS_USE_PKG_CONFIG
  cargo:rerun-if-env-changed=SQLITE3_INCLUDE_DIR
  cargo:rerun-if-env-changed=SQLITE3_LIB_DIR
  cargo:rerun-if-env-changed=SQLITE3_STATIC
  cargo:link-target=sqlite3
  cargo:rerun-if-env-changed=SQLITE3_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=SQLITE3_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=SYSROOT
  cargo:rerun-if-env-changed=SQLITE3_STATIC
  cargo:rustc-link-search=native=/usr/lib/x86_64-linux-gnu
  cargo:rustc-link-lib=sqlite3
  cargo:rustc-link-lib=m
  cargo:rustc-link-lib=z
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=SQLITE3_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=LIBSQLITE3_SYS_BUNDLING

  --- stderr

  thread 'main' (5223) panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libsqlite3-sys-0.30.1/build.rs:620:33:
  could not run bindgen on header target/cadmus-build-deps/x86_64-unknown-linux-gnu/sqlite/include/sqlite3.h
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Error: Process completed with exit code 101.

Copilot AI requested a review from OGKevin June 10, 2026 09:09
@OGKevin
OGKevin force-pushed the copilot/ogkevinpushqvslmuwsvkks branch from 7bc8b89 to 548ae9f Compare June 10, 2026 10:07
@OGKevin
OGKevin temporarily deployed to cloudflare-pages-preview June 10, 2026 10:10 — with GitHub Actions Inactive
@OGKevin
OGKevin force-pushed the copilot/ogkevinpushqvslmuwsvkks branch from 548ae9f to 8e30a85 Compare June 11, 2026 06:49
@OGKevin
OGKevin temporarily deployed to cloudflare-pages-preview June 11, 2026 06:52 — with GitHub Actions Inactive
Copilot AI and others added 2 commits June 11, 2026 09:19
Cargo build scripts for registry crates (like libsqlite3-sys) run with
the crate's registry source directory as their working directory, not the
workspace root. When SQLITE3_INCLUDE_DIR is set to a relative path,
bindgen passes that path to libclang which resolves it relative to the
build script's CWD — where the file does not exist — causing the panic:

  could not run bindgen on header target/cadmus-build-deps/…/sqlite3.h

Fix: use ${{ github.workspace }} in the workflow and $DEVENV_ROOT in
devenv.nix to make both paths absolute at runtime.

Co-authored-by: OGKevin <17928966+OGKevin@users.noreply.github.com>
@OGKevin
OGKevin force-pushed the ogkevin/push/qvslmuwsvkks branch from 8b3b923 to 1ee72a5 Compare June 11, 2026 07:43
@OGKevin
OGKevin force-pushed the copilot/ogkevinpushqvslmuwsvkks branch from 8e30a85 to 6e3df5f Compare June 11, 2026 07:43
@OGKevin
OGKevin temporarily deployed to cloudflare-pages-preview June 11, 2026 07:52 — with GitHub Actions Inactive
@OGKevin
OGKevin force-pushed the copilot/ogkevinpushqvslmuwsvkks branch from 6e3df5f to 344da0b Compare June 11, 2026 08:23
@OGKevin
OGKevin temporarily deployed to cloudflare-pages-preview June 11, 2026 08:27 — with GitHub Actions Inactive
@OGKevin
OGKevin force-pushed the copilot/ogkevinpushqvslmuwsvkks branch from 344da0b to eeb2fe4 Compare June 11, 2026 08:56
@OGKevin
OGKevin temporarily deployed to cloudflare-pages-preview June 11, 2026 09:00 — with GitHub Actions Inactive
@OGKevin
OGKevin force-pushed the copilot/ogkevinpushqvslmuwsvkks branch from eeb2fe4 to 43454f1 Compare June 11, 2026 09:43
Change-Id: 8cc25f3dbefa02393f87d1de13859b99
Change-Id-Short: rnnxukwmolkp
@OGKevin
OGKevin had a problem deploying to cloudflare-pages-preview June 11, 2026 09:46 — with GitHub Actions Error
@OGKevin
OGKevin force-pushed the copilot/ogkevinpushqvslmuwsvkks branch from 43454f1 to 6b610b6 Compare June 11, 2026 09:46
@OGKevin
OGKevin marked this pull request as ready for review June 11, 2026 09:53
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. Refactor labels Jun 11, 2026
@OGKevin OGKevin changed the title [WIP] Refactor use DELETE ... LIMIT chore: refactor Jun 11, 2026
@OGKevin
OGKevin merged commit bdd7e5a into ogkevin/push/qvslmuwsvkks Jun 11, 2026
76 checks passed
@OGKevin
OGKevin deleted the copilot/ogkevinpushqvslmuwsvkks branch June 11, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants