docs: update build/devenv docs for thirdparty submodules and auto setup#578
Conversation
- Remove deps:native task and cadmus-setup-native script (setup-native xtask no longer exists) - Remove --slow flag from build:kobo task and cadmus-build-kobo script (flag was removed from the build-kobo xtask CLI) - Remove setup-native references from enterShell help text - Regenerate docs/po/messages.pot to reflect English doc source changes
- Fix thirdparty/AGENTS.md: build-deps/src/versions.rs → crates/build-deps/src/versions.rs (2 occurrences) - Fix build-scripts/mupdf/README.md: replace stale cargo xtask setup-native reference with build-deps build.rs - Update docs/po/xx.po via msgmerge to remove stale setup-native msgid
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (3)docs/src/**/*.md📄 CodeRabbit inference engine (docs/AGENTS.md)
Files:
docs/src/contributing/**/*.md📄 CodeRabbit inference engine (docs/AGENTS.md)
Files:
docs/**/*.md📄 CodeRabbit inference engine (docs/AGENTS.md)
Files:
🧠 Learnings (26)📓 Common learnings📚 Learning: 2026-05-27T00:35:26.129ZApplied to files:
📚 Learning: 2026-05-26T20:10:56.991ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-25T12:43:50.793ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-06-06T19:59:31.071ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-27T15:13:37.212ZApplied to files:
📚 Learning: 2026-06-04T12:03:49.867ZApplied to files:
📚 Learning: 2026-06-04T12:03:49.867ZApplied to files:
📚 Learning: 2026-06-04T12:03:49.867ZApplied to files:
📚 Learning: 2026-05-31T07:53:12.579ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
📚 Learning: 2026-05-28T14:01:38.823ZApplied to files:
🪛 LanguageToolthirdparty/AGENTS.md[style] ~61-~61: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE) 🔇 Additional comments (6)
WalkthroughThis PR consolidates native dependency building into Sequence Diagram(s)The changes are primarily documentation and configuration updates reflecting an internal implementation shift—no new feature interactions or multi-component flows are introduced that would warrant a sequence diagram. The architectural change (moving build logic from Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Update documentation for #571
Documentation now reflects that thirdparty C/C++ dependencies are managed as git submodules (tracked via
.gitmodules) and built automatically by thebuild-depscrate/build.rs, rather than using a one-timecargo xtask setup-nativestep or xtask-managed version constants. The AGENTS guide was updated to describe the new per-librarybuild-scripts/<lib>/layout, dependency-order source of truth inbuild-deps/src/versions.rs, and Renovate'sgit-submodulestracking workflow. The devenv-setup and SKILL pages were revised to removesetup-nativefrom the required workflow, adjust emulator/build-kobo host support (Linux and macOS), and update the listed build modes and prerequisites accordingly.Follow-up fixes
Cleans up stale references that would error at runtime or mislead developers:
devenv.nix: Removeddeps:nativetask,cadmus-setup-nativescript, and--slowflag frombuild:kobo/cadmus-build-kobo(thesetup-nativextask and--slowCLI flag no longer exist)thirdparty/AGENTS.md: Fixedbuild-deps/src/versions.rs→crates/build-deps/src/versions.rs(2 occurrences)build-scripts/mupdf/README.md: Replaced stalecargo xtask setup-nativereference withbuild-depscrate'sbuild.rsdocs/po/messages.pot: Regenerated to reflect English doc source changesdocs/po/xx.po: Merged against updated.potto remove stalesetup-nativemsgidGenerated by Dosu
Link to Devin session: https://app.devin.ai/sessions/508d9277efa2403da78a7e04c8020e3b
Requested by: @OGKevin