Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
From 4613616542c78090e1271153a44faf21cd927398 Mon Sep 17 00:00:00 2001
From: Ilies CHERGUI <ichergui@nvidia.com>
Date: Tue, 19 Aug 2025 13:13:01 +0100
Subject: [PATCH] cmake: Set minimum required version to 3.5 for CMake 4+
compatibility

Fix:

| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
| Compatibility with CMake < 3.5 has been removed from CMake.
|
| Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
| to tell CMake that the project requires at least <min> but has been updated
| to work with policies introduced by <max> or earlier.
|
| Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
|
|
| -- Configuring incomplete, errors occurred!

Upstream-Status: Inappropriate [OE-specific]
Signed-off-by: Ilies CHERGUI <ichergui@nvidia.com>
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index cb9f4f1..78712aa 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,5 +1,5 @@
# CMakeLists to build the cnmem library.
-cmake_minimum_required(VERSION 2.8.8)
+cmake_minimum_required(VERSION 3.5)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream seems to be dormant but it will be good to create a PR for it there as well.

project(cnmem)

# We need CUDA to build that library.
--
2.34.1

5 changes: 4 additions & 1 deletion recipes-devtools/cnmem/cnmem_v1.0.0.bb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ DESCRIPTION = "A simple memory manager for CUDA designed to help Deep Learning f
LICENSE = "BSD-3-Clause"
LIC_FILES_CHKSUM = "file://LICENSE;md5=927dd052e0c449ac0dd2c0b54d67626d"

SRC_URI = "git://github.com/NVIDIA/cnmem.git;protocol=https;branch=master"
SRC_URI = " \
git://github.com/NVIDIA/cnmem.git;protocol=https;branch=master \
file://0001-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \
"

SRCREV = "c5573333feed2526d4301fca103c55cf3bcb9dcc"

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
From 7957c0c1a736be3ce76a486e07fee995039cda13 Mon Sep 17 00:00:00 2001
From: Ilies CHERGUI <ichergui@nvidia.com>
Date: Tue, 19 Aug 2025 14:34:51 +0100
Subject: [PATCH 2/2] cmake: Set minimum required version to 3.5 for CMake 4+
compatibility

Fix:

| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
| Compatibility with CMake < 3.5 has been removed from CMake.
|
| Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
| to tell CMake that the project requires at least <min> but has been updated
| to work with policies introduced by <max> or earlier.
|
| Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
|
|
| -- Configuring incomplete, errors occurred!

Upstream-Status: Inappropriate [OE-specific]
Signed-off-by: Ilies CHERGUI <ichergui@nvidia.com>
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ed9671a..cffe76b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -2,7 +2,7 @@
# Set minimum version of CMake. Since command 'project' use
# VERSION sub-option we need at least 3.0.
# Note: If you use 2.6 or 2.4, God kills a kitten. Seriously.
-cmake_minimum_required(VERSION 3.2 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.5 FATAL_ERROR)

####
# Set variables:
--
2.34.1

1 change: 1 addition & 0 deletions recipes-devtools/dlpack/dlpack_1.0.bb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f62d4e85ba68a1574b74d97ab8dea9ab"
SRC_URI = " \
git://github.com/dmlc/dlpack.git;protocol=https;branch=main;tag=v${PV} \
file://0001-update-dlpack-project-version.patch \
file://0002-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets backport dmlc/dlpack@5c210da from upstream instead.

"
SRCREV = "bbd2f4d32427e548797929af08cfe2a9cbb3cf12"

Expand Down
70 changes: 62 additions & 8 deletions recipes-devtools/libevhtp/libevhtp/0001-fix-cmake-build.patch
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
From 491ecafe3b3b8651fa51a3234170cabb394e15d8 Mon Sep 17 00:00:00 2001
From: Roger Knecht <roger@norberthealth.com>
Date: Wed, 22 Jun 2022 11:17:05 +0200
Subject: [PATCH] fix cmake build
From 7270f3bf9f42dbdda847c79b232697d6f09d548f Mon Sep 17 00:00:00 2001
From: Ilies CHERGUI <ichergui@nvidia.com>
Date: Tue, 19 Aug 2025 16:12:20 +0100
Subject: [PATCH 1/2] fix cmake build

Upstream-Status: Pending
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Ilies CHERGUI <ichergui@nvidia.com>
---
CMakeLists.txt | 4 ++--
cmake/Config.cmake.in | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
CMakeLists.txt | 4 ++--
cmake/Config.cmake.in | 3 +++
cmake/TestBigEndian.cmake | 18 +++++++++---------
3 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 481ddd0..dcf5685 100644
Expand Down Expand Up @@ -40,6 +42,58 @@ index b834857..20a2e07 100644
set(package_deps @package_deps@)
foreach(dep IN LISTS package_deps)
find_package(${dep} REQUIRED)
diff --git a/cmake/TestBigEndian.cmake b/cmake/TestBigEndian.cmake
index fdc3adb..d9c7d31 100644
--- a/cmake/TestBigEndian.cmake
+++ b/cmake/TestBigEndian.cmake
@@ -56,25 +56,25 @@ macro(TEST_BIG_ENDIAN VARIABLE)
endif()


- configure_file("${CMAKE_ROOT}/Modules/TestEndianess.c.in"
- "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/TestEndianess.c"
+ configure_file("${CMAKE_ROOT}/Modules/TestEndianness.c.in"
+ "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/TestEndianness.c"
@ONLY)

- file(READ "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/TestEndianess.c"
+ file(READ "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/TestEndianness.c"
TEST_ENDIANESS_FILE_CONTENT)

try_compile(HAVE_${VARIABLE}
"${CMAKE_BINARY_DIR}"
- "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/TestEndianess.c"
+ "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/TestEndianness.c"
OUTPUT_VARIABLE OUTPUT
- COPY_FILE "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/TestEndianess.bin" )
+ COPY_FILE "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/TestEndianness.bin" )

if(HAVE_${VARIABLE})

- file(STRINGS "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/TestEndianess.bin"
+ file(STRINGS "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/TestEndianness.bin"
CMAKE_TEST_ENDIANESS_STRINGS_LE LIMIT_COUNT 1 REGEX "THIS IS LITTLE ENDIAN")

- file(STRINGS "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/TestEndianess.bin"
+ file(STRINGS "${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/TestEndianness.bin"
CMAKE_TEST_ENDIANESS_STRINGS_BE LIMIT_COUNT 1 REGEX "THIS IS BIG ENDIAN")

# on mac, if there are universal binaries built both will be true
@@ -105,12 +105,12 @@ macro(TEST_BIG_ENDIAN VARIABLE)
endif()

file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeOutput.log
- "Determining if the system is big endian passed with the following output:\n${OUTPUT}\nTestEndianess.c:\n${TEST_ENDIANESS_FILE_CONTENT}\n\n")
+ "Determining if the system is big endian passed with the following output:\n${OUTPUT}\nTestEndianness.c:\n${TEST_ENDIANESS_FILE_CONTENT}\n\n")

else()
message(STATUS "Check if the system is big endian - failed")
file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log
- "Determining if the system is big endian failed with the following output:\n${OUTPUT}\nTestEndianess.c:\n${TEST_ENDIANESS_FILE_CONTENT}\n\n")
+ "Determining if the system is big endian failed with the following output:\n${OUTPUT}\nTestEndianness.c:\n${TEST_ENDIANESS_FILE_CONTENT}\n\n")
set(${VARIABLE})
endif()
endif()
--
2.17.1
2.34.1

Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
From 92ff749866dc8e826021622f8b8dc59e2a54b3bd Mon Sep 17 00:00:00 2001
From: Ilies CHERGUI <ichergui@nvidia.com>
Date: Tue, 19 Aug 2025 16:12:55 +0100
Subject: [PATCH 2/2] cmake: Set minimum required version to 3.5 for CMake 4+
compatibility

Fix:

| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
| Compatibility with CMake < 3.5 has been removed from CMake.
|
| Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
| to tell CMake that the project requires at least <min> but has been updated
| to work with policies introduced by <max> or earlier.
|
| Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
|
|
| -- Configuring incomplete, errors occurred!

Upstream-Status: Inappropriate [OE-specific]
Signed-off-by: Ilies CHERGUI <ichergui@nvidia.com>
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index dcf5685..a404c2d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.1)
+cmake_minimum_required(VERSION 3.5)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if its working, perhaps its worth letting upstream have a look at this patch.


list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake)

--
2.34.1

1 change: 1 addition & 0 deletions recipes-devtools/libevhtp/libevhtp_1.2.18.bb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=68e2a80f5f9020a66f4512962817cd66"
SRC_URI = " \
git://github.com/Yellow-Camper/libevhtp.git;protocol=https;branch=master \
file://0001-fix-cmake-build.patch \
file://0002-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \
"

SRCREV = "e200bfa85bf253e9cfe1c1a9e705fccb176b9171"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
From 46e0bdcd591d25e13423d5e704388d33b5e5ede1 Mon Sep 17 00:00:00 2001
From: Ilies CHERGUI <ichergui@nvidia.com>
Date: Tue, 19 Aug 2025 15:23:12 +0100
Subject: [PATCH 7/7] cmake: Set minimum required version to 3.5 for CMake 4+
compatibility

Fix:

| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
| Compatibility with CMake < 3.5 has been removed from CMake.
|
| Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
| to tell CMake that the project requires at least <min> but has been updated
| to work with policies introduced by <max> or earlier.
|
| Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
|
|
| -- Configuring incomplete, errors occurred!

Upstream-Status: Inappropriate [OE-specific]
Signed-off-by: Ilies CHERGUI <ichergui@nvidia.com>
---
third_party/FP16/CMakeLists.txt | 2 +-
third_party/NNPACK/CMakeLists.txt | 2 +-
third_party/gloo/CMakeLists.txt | 2 +-
third_party/psimd/CMakeLists.txt | 2 +-
third_party/tensorpipe/third_party/libuv/CMakeLists.txt | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/third_party/FP16/CMakeLists.txt b/third_party/FP16/CMakeLists.txt
index e0d87f86c..1fee16e14 100644
--- a/third_party/FP16/CMakeLists.txt
+++ b/third_party/FP16/CMakeLists.txt
@@ -1,4 +1,4 @@
-CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12 FATAL_ERROR)
+CMAKE_MINIMUM_REQUIRED(VERSION 3.5 FATAL_ERROR)

INCLUDE(GNUInstallDirs)

diff --git a/third_party/NNPACK/CMakeLists.txt b/third_party/NNPACK/CMakeLists.txt
index d808915a4..335073dba 100644
--- a/third_party/NNPACK/CMakeLists.txt
+++ b/third_party/NNPACK/CMakeLists.txt
@@ -1,4 +1,4 @@
-CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12 FATAL_ERROR)
+CMAKE_MINIMUM_REQUIRED(VERSION 3.5 FATAL_ERROR)

INCLUDE(GNUInstallDirs)
INCLUDE(CheckCSourceCompiles)
diff --git a/third_party/gloo/CMakeLists.txt b/third_party/gloo/CMakeLists.txt
index b0db65e69..e9c66400c 100644
--- a/third_party/gloo/CMakeLists.txt
+++ b/third_party/gloo/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.5 FATAL_ERROR)

project(gloo CXX C)

diff --git a/third_party/psimd/CMakeLists.txt b/third_party/psimd/CMakeLists.txt
index bd69c6202..4ba1fed29 100644
--- a/third_party/psimd/CMakeLists.txt
+++ b/third_party/psimd/CMakeLists.txt
@@ -1,4 +1,4 @@
-CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12 FATAL_ERROR)
+CMAKE_MINIMUM_REQUIRED(VERSION 3.5 FATAL_ERROR)

INCLUDE(GNUInstallDirs)

diff --git a/third_party/tensorpipe/third_party/libuv/CMakeLists.txt b/third_party/tensorpipe/third_party/libuv/CMakeLists.txt
index 09996d2ab..9c0be8c29 100644
--- a/third_party/tensorpipe/third_party/libuv/CMakeLists.txt
+++ b/third_party/tensorpipe/third_party/libuv/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.5)
project(libuv LANGUAGES C)

cmake_policy(SET CMP0057 NEW) # Enable IN_LIST operator
--
2.34.1

1 change: 1 addition & 0 deletions recipes-devtools/pytorch/pytorch_2.5.0.bb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ SRC_URI += " \
file://0004-Use-native-protobuf-compiler.patch \
file://0005-Disable-various-warnings.patch \
file://0006-Fixups-for-cross-building-in-OE.patch \
file://0007-cmake-Set-minimum-required-version-to-3.5-for-CMake-.patch \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets backport - pytorch/pytorch@c2beead

"

S = "${UNPACKDIR}/${PN}-v${PV}"
Expand Down
Loading