improve logging and page validator#1359
Merged
Merged
Conversation
added 5 commits
May 5, 2026 16:07
kba
approved these changes
May 5, 2026
| @click.option('--page-coordinate-consistency', help="How fierce to check PAGE multi-level coordinate consistency", | ||
| type=click.Choice(['poly', 'baseline', 'both', 'off']), default='poly') | ||
| @click.option('-q', '--include-file-grps', 'include_fileGrp', help="fileGrps to include", default=[], multiple=True) | ||
| @click.option('-Q', '--exclude-file-grps', 'exclude_fileGrp', help="fileGrps to exclude", default=[], multiple=True) |
Member
There was a problem hiding this comment.
Good for consistency and useful for doing targeted validation of experimental workspaces with lots of groups.
| logging.root.handlers = [logging.handlers.QueueHandler(log_queue)] | ||
| logging.root.handlers[0].setFormatter( | ||
| # insert pageId before actual message | ||
| logging.Formatter(fmt='[%(pageId)s] %(message)s')) |
Member
There was a problem hiding this comment.
Very useful for debugging. An eventual (yet another) refactoring of the logging to provide such metadata per-message throughout would be tremendous. "Wenn mal Zeit ist..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sry, another non-topical PR ...
-l DEBUGocrd workspace validateto easily filter in/out fileGrps (just delegate existing functionality to CLI)