Skip to content

[IMP] shopfloor: Allow to partially reserve in location_content_transfer - #1225

Open
rousseldenis wants to merge 1 commit into
OCA:16.0from
acsone:16.0-imp-shopfloor-location_content_availabl-dro
Open

[IMP] shopfloor: Allow to partially reserve in location_content_transfer#1225
rousseldenis wants to merge 1 commit into
OCA:16.0from
acsone:16.0-imp-shopfloor-location_content_availabl-dro

Conversation

@rousseldenis

Copy link
Copy Markdown

When several users are working on a content transfer (e.g.: put away from input locations), scanning the source location will result in an error as some products are already reserved.

Improve also the message for the operator

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @guewen, @sebalix, @simahawk,
some modules you are maintaining are being modified, check this out!

@rousseldenis

Copy link
Copy Markdown
Author

@jbaudoux

@sebalix sebalix left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, LG

"body": _("New move lines cannot be assigned: canceled."),
"body": _(
"Some products in the source location are already reserved. "
"It's impossible to reserve them!"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"It's impossible to reserve them!"
"It's impossible to reserve them."

I would avoid the exclamation mark in messages returned to the user?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, less pressure but we know they don't read them at all 😃

Comment on lines +87 to +88
allow_reserve_only_available = fields.Boolean(
string="Allow to reserve only available quantities on source location",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with location content transfer we want to move the goods, is "reserve" the right word here? Suggestion:

Suggested change
allow_reserve_only_available = fields.Boolean(
string="Allow to reserve only available quantities on source location",
allow_moving_only_available = fields.Boolean(
string="Allow to move only available quantities on source location",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, this is for quant quantities reservations, the 'move' is the next step :-)

When several users are working on a content transfer (e.g.: put away from input locations),
scanning the source location will result in an error as some products are already reserved.

Improve also the message for the operator
@rousseldenis
rousseldenis force-pushed the 16.0-imp-shopfloor-location_content_availabl-dro branch from 1dc88ec to d77069a Compare July 29, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants