[19.0][MIG] stock_picking_report_summary: Migration to 19.0 - #518
[19.0][MIG] stock_picking_report_summary: Migration to 19.0#518Sadiq-OSI wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:19.0
mod:stock_picking_report_summary
ffc472e to
bd740da
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
This is the report generated from v18:
Picking Summary (1).pdf
This is the report generated from v19:
Picking Summary.pdf
Compared to the v18 report, the v19 version has some extra whitespace at the top of the first page. It would be good to adjust the layout so the report looks correct and is visually consistent.
bd740da to
cee7ef3
Compare
Done. Made the change and committed it. |
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Functional review LGTM!
|
/ocabot migration stock_picking_report_summary |
| version = "19.0.20260317.0" | ||
| dependencies = [ | ||
| "odoo-addon-stock_picking_report_external_note==19.0.*", | ||
| "odoo-addon-stock_picking_report_summary==19.0.*", |
There was a problem hiding this comment.
@Sadiq-OSI Is that done by pre-commit? I thought it was at merge by bot.
There was a problem hiding this comment.
Good catch, thanks. I removed the manual update from setup/_metapackage/pyproject.toml and pushed the branch again. This should be handled by the post-merge bot.
rousseldenis
left a comment
rousseldenis
left a comment
There was a problem hiding this comment.
@Sadiq-OSI Thanks for this. Could you squash your two last commits ?
| addon | version | maintainers | summary | ||
| --- | --- | --- | --- | ||
| [stock_picking_report_external_note](stock_picking_report_external_note/) | 19.0.1.0.0 | <a href='https://github.com/Shide'><img src='https://github.com/Shide.png' width='32' height='32' style='border-radius:50%;' alt='Shide'/></a> | Adds a note in Stock Picking shown on external reports like Delivery Slip | ||
| [stock_picking_report_summary](stock_picking_report_summary/) | 19.0.1.0.0 | <a href='https://github.com/quentinDupont'><img src='https://github.com/quentinDupont.png' width='32' height='32' style='border-radius:50%;' alt='quentinDupont'/></a> <a href='https://github.com/legalsylvain'><img src='https://github.com/legalsylvain.png' width='32' height='32' style='border-radius:50%;' alt='legalsylvain'/></a> | Stock Picking Report Summary |
There was a problem hiding this comment.
Don't change that. It will be by the bot at merge.
| "website": "https://github.com/OCA/stock-logistics-reporting", | ||
| "category": "Warehouse Management", | ||
| "license": "AGPL-3", | ||
| "application": False, |
There was a problem hiding this comment.
That's the default value.
There was a problem hiding this comment.
I removed the root README entry so the bot can handle it at merge, and also removed the redundant application=False from the manifest.
There was a problem hiding this comment.
Squashed the commits as well.
d561ff4 to
cba98aa
Compare
cba98aa to
ab56541
Compare
4 participants
Summary
stock_picking_report_summaryfrom 18.0 to 19.0.Validation
git diff --check0 failed, 0 error(s)0 failed, 0 error(s)