[19.0][MIG] stock_picking_report_delivery_custom_name: Migration to 19.0 - #497
[19.0][MIG] stock_picking_report_delivery_custom_name: Migration to 19.0#497chienandalu wants to merge 6 commits into
Conversation
MT-4027 MT-10331
OCA-git-bot
added
series:19.0
mod:stock_picking_report_delivery_custom_name
EmilioPascual
left a comment
EmilioPascual
left a comment
There was a problem hiding this comment.
@chienandalu good job
Functional and code review
|
@fcvalgar please review |
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Just a minor suggestion: could we use BaseCommon here? That way, we wouldn’t need to create a res.partner record manually.
b4ba66a to
e4e19ad
Compare
|
Suggestions applied @BhaveshHeliconia |
fcvalgar
left a comment
fcvalgar
left a comment
There was a problem hiding this comment.
Great work on this contribution @chienandalu . I have tested the module and the feature works as expected.
The following tests were performed:
Test 1: OK - Delivery slip with product delivery description. The report displayed the public delivery description and did not show the internal product name.
Test 2: OK - Delivery slip before validating the transfer. The report correctly displayed the custom delivery description on pending operations.
Test 3: OK - Delivery slip after validating the transfer. The report correctly displayed the custom delivery description on done operations.
Test 4: OK - Product without delivery description. The report kept the standard Odoo behavior and displayed the product name.
Test 5: OK - Delivery description equal to the product name. The product name was displayed only once and was not duplicated.
Test 6: OK - Manually edited description on the transfer operation. The report displayed the custom operation description and hid the internal product name.
Test 7: OK - Delivery slip with multiple products, some with custom descriptions and others without. The logic was correctly applied per line.
Test 8: OK - Sensitive internal product name not visible in the report. The delivery slip only displayed the public description.
Test 9: OK - Standard behavior for products without special configuration. The delivery slip remained unchanged.
Everything looks good to me, so I approve this PR.
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code and functional review LGTM!
|
/ocabot migration stock_picking_report_delivery_custom_name |
rafaelbn
left a comment
rafaelbn
left a comment
There was a problem hiding this comment.
Functional test 👍🏼
/ocabot merge patch
|
On my way to merge this fine PR! |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-497-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-497-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
e4e19ad to
b4a340f
Compare
|
Rebased to fix errors. Please @rafaelbn try to merge again |
|
This PR has the |
7 participants
cc @moduon MT-14456
please review @EmilioPascual @fcvalgar