[18.0][MIG] report_qweb_signer: Migration to 18.0 by chienandalu · Pull Request #1105 · OCA/reporting-engine

chienandalu · 2025-12-17T11:41:14Z

superseds #1060

Refactor to use pyHanko and the new Odoo core certificate.certificate model.

For now, a minimal refactor has been made as PoC to:

Use PyHanko as the signer library (more complete, mantained and reliable)
Remove all the forme java pdfsigner stuff.
Be able to use Odoo core certificates.

Main pain points:

cryptography version is fixed in Odoo requirements.txt. This makes very hard for other libraries to work with that version.
The approach has been using the pyhanko-cli tool as backend so we can install it in it's own venv (or whatever isolation method is desired).

cc @moduon MT-11131

fyi @yajo

yajo

Thanks for the good work, it looks much better indeed.

Code review with some comments in code.

Please also review tests, which are failing.

yajo · 2026-01-21T09:00:40Z

+def migrate(cr, version):
+    # 1. Store certificate info (file path) to create the certs on post-mig
+    # 2. Transform report.certificate to their reports values
+    pass


issue: missing implementation.

yajo · 2026-01-21T09:02:28Z

+            and self.signing_allow_only_one
+            and len(res_ids) > 1
+        ):
+            _logger.debug(


suggestion: higher importance

Suggested change

_logger.debug(

_logger.warning(

yajo · 2026-01-21T09:04:47Z

+            ids = set(
+                self.env[self.model_id.model].search(safe_eval(self.signing_domain)).ids
+            )
+            res_ids = list(ids & set(res_ids))


Suggested change

ids = set(

self.env[self.model_id.model].search(safe_eval(self.signing_domain)).ids

)

res_ids = list(ids & set(res_ids))

res_ids = self.env[self.model_id.model].search([("id", "in", res_ids)] + safe_eval(self.signing_domain)).ids

yajo · 2026-01-21T09:05:33Z

+
+    def _should_be_signed(self, res_ids: list) -> list:
+        """Not all the documents should be rendered. Let's find out the right ones"""
+        if not self._is_report_type_signable():


Suggested change

if not self._is_report_type_signable():

if not self._is_report_type_signable() or not res_ids:

yajo · 2026-01-21T09:09:28Z

@@ -6,10 +6,10 @@
  > - Jairo Llopis
  > - David Vidal


suggestion: IMHO Moduon deserves a mention, after this huge refactor.

github-actions · 2026-05-24T13:26:30Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

chienandalu · 2026-05-25T07:07:34Z

@yajo set to no stale, please

yajo · 2026-06-23T07:55:36Z

Tests are broken. Would you fix them please?

OCA Transbot updated translations from Transifex

These limits were being hit when printing PDF reports with just 80 pages. OCA Transbot updated translations from Transifex [UPD] Update report_qweb_signer.pot

- Good dependency chain - Context for forcing rendering PDF - Extra test [UPD] README.rst [UPD] Update report_qweb_signer.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/ [UPD] README.rst

`render_qweb_pdf` must return a tuple of `(content, 'pdf')`

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/

Fix website on manifest

[UPD] Update report_qweb_signer.pot [UPD] README.rst

Currently translated at 26.0% (12 of 46 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/it/

Currently translated at 63.0% (29 of 46 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/sl/

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/ca/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-16.0/reporting-engine-16.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_qweb_signer/

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_qweb_signer/es/

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_qweb_signer/it/

…es of pdf

…ography version for python < 3.12

Refactor to use pyHanko and the new Odoo core `certificate.certificate` model. For now, a minimal refactor has been made as PoC to: - Use PyHanko as the signer library (more complete, mantained and reliable) - Remove all the forme java pdfsigner stuff. - Be able to use Odoo core certificates. Main pain points: - `cryptography` version is fixed in Odoo `requirements.txt`. This makes very hard for other libraries to work with that version. - The approach has been using the `pyhanko-cli` tool as backend so we can install it in it's own `venv` (or whatever isolation method is desired). MT-11131

chienandalu force-pushed the 18.0-mig-report_qweb_signer branch 2 times, most recently from 71070b5 to 212514f Compare December 18, 2025 12:06

yajo requested changes Jan 21, 2026

View reviewed changes

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 24, 2026

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 31, 2026

yajo added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Jun 23, 2026

chienandalu force-pushed the 18.0-mig-report_qweb_signer branch from 212514f to 0485c9f Compare August 3, 2026 10:27

OCA-git-bot added series:18.0 mod:report_qweb_signer Module report_qweb_signer labels Aug 3, 2026

chienandalu force-pushed the 18.0-mig-report_qweb_signer branch from 0485c9f to 15640b2 Compare August 3, 2026 10:28

antespi and others added 17 commits August 3, 2026 12:56

report_qweb_signer addon

fba0144

report_qweb_signer: Add feature request

053786d

OCA Transbot updated translations from Transifex

[MIG] report_qweb_signer: Migration to 10.0

56d84e2

OCA Transbot updated translations from Transifex

fix test_report_qweb_signer - tests were causing travis to stall

846d528

[FIX] report_qweb_signer: Remove hardcoded memory limits

25b83ee

These limits were being hit when printing PDF reports with just 80 pages. OCA Transbot updated translations from Transifex [UPD] Update report_qweb_signer.pot

[FIX] README syntax

080bf2c

[MIG] report_qweb_designer: Migration to 12.0

23d8854

[FIX] report_qweb_signer: reprint report crash

ea8d7a2

`render_qweb_pdf` must return a tuple of `(content, 'pdf')`

[FIX] report_qweb_signer

cd55986

Fix website on manifest

[IMP] report_qweb_signer: Black python code

1620211

[MIG] report_qweb_signer: Migration to 13.0

6468220

[UPD] Update report_qweb_signer.pot [UPD] README.rst

Apply dotfiles

38d8c17

report_qweb_signer 13.0.1.0.1

0a472e9

[IMP] report_qweb_signer add endesive

4bb5141

[UPD] Update report_qweb_signer.pot

7c4282c

OCA-git-bot and others added 29 commits August 3, 2026 12:56

[UPD] README.rst

7868925

report_qweb_signer 14.0.2.0.1

bc6a80d

Update CONFIGURE.rst

4e692b5

[UPD] README.rst

70df3c9

report_qweb_signer 14.0.2.0.2

868bafc

[UPD] README.rst

d4ee980

[IMP] pre-commit lint

bffce4f

[UPD] Update report_qweb_signer.pot

d1385b0

[BOT] post-merge updates

d9db2fb

[MIG] report_qweb_signer to 16.0

96914f2

[UPD] Update report_qweb_signer.pot

9dc9bd9

[BOT] post-merge updates

9f61e41

[IMP] add missing _is_report_type_signable to allow signing other typ…

47d634c

…es of pdf

[BOT] post-merge updates

b8e936f

[REF] report_qweb_signer: make signing functions reusable

694e165

[BOT] post-merge updates

f70ca16

[FIX] endesive 2.19.0 version is not compatible with odoo pined crypt…

74e5c67

…ography version for python < 3.12

[BOT] post-merge updates

342b1e0

[IMP] report_qweb_signer: pre-commit auto fixes

1890400

[TEST] add isolated pyhanko

5f37645

chienandalu force-pushed the 18.0-mig-report_qweb_signer branch from 15640b2 to 5f37645 Compare August 3, 2026 10:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] report_qweb_signer: Migration to 18.0 - #1105

[18.0][MIG] report_qweb_signer: Migration to 18.0 #1105
chienandalu wants to merge 64 commits into
OCA:18.0from
moduon:18.0-mig-report_qweb_signer

chienandalu commented Dec 17, 2025

Uh oh!

yajo left a comment

Uh oh!

yajo Jan 21, 2026

Uh oh!

yajo Jan 21, 2026

Uh oh!

yajo Jan 21, 2026

Uh oh!

yajo Jan 21, 2026

Uh oh!

yajo Jan 21, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

chienandalu commented May 25, 2026

Uh oh!

yajo commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

	if not self._is_report_type_signable():
	if not self._is_report_type_signable() or not res_ids:

Uh oh!

Uh oh!

Conversation

chienandalu commented Dec 17, 2025

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

yajo Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

yajo Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

yajo Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

yajo Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

yajo Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

chienandalu commented May 25, 2026

Uh oh!

yajo commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants