Skip to content

[FIX] purchase_request: bind name before use in onchange_product_id #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mav-adhoc wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+3 −2
Open

[FIX] purchase_request: bind name before use in onchange_product_id #3136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions purchase_request/wizard/purchase_request_line_make_purchase_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,9 @@ class PurchaseRequestLineMakePurchaseOrderItem(models.TransientModel):
@api.onchange("product_id")
def onchange_product_id(self):
if self.product_id:
if not self.keep_description:
name = self.product_id.name
# Always bind ``name`` to avoid UnboundLocalError when
# ``keep_description`` is set.
name = self.name if self.keep_description else self.product_id.name
code = self.product_id.code
sup_info_id = self.env["product.supplierinfo"].search(
[
Expand Down
Loading