Skip to content

[FIX] use authenticated GitHub API to check maintainers in other branches - #357

Open
yajo wants to merge 1 commit into
OCA:masterfrom
moduon:fix-226-maintainer-other-branches-auth
Open

[FIX] use authenticated GitHub API to check maintainers in other branches#357
yajo wants to merge 1 commit into
OCA:masterfrom
moduon:fix-226-maintainer-other-branches-auth

Conversation

@yajo

@yajo yajo commented Jul 30, 2026

Copy link
Copy Markdown
Member

When a maintainer tried to merge or rebase a migration PR, the bot
looked for maintainers in other branches by downloading each addon
manifest from raw.githubusercontent.com. That endpoint is unauthenticated
and subject to rate limiting, transient errors and caching issues, which
made the check fail intermittently (see #226).

With this change, the authenticated GitHub session already used by the
bot is reused to read manifests via the GitHub Contents API. The previous
raw URL request is kept as a fallback in case the API is unavailable.

Fixes #226

Assisted-by: OpenCode + kimi-k2.7-code

@legalsylvain

Copy link
Copy Markdown
Collaborator

Could you take a look on red CI ?

Thanks !

@legalsylvain
legalsylvain marked this pull request as draft July 30, 2026 17:47
@yajo
yajo force-pushed the fix-226-maintainer-other-branches-auth branch from 060b0c2 to 1480a4c Compare July 31, 2026 11:16
@yajo
yajo marked this pull request as ready for review July 31, 2026 11:17
@yajo

yajo commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

Done, was just formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintainer are not able to merge / rebase their modules when migrating

2 participants