[15.0][ADD] mis_report_account_coverage_check: New module - #821
Closed
carlosdauden wants to merge 1 commit into
Closed
[15.0][ADD] mis_report_account_coverage_check: New module#821carlosdauden wants to merge 1 commit into
carlosdauden wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:15.0
mod:mis_report_account_coverage_check
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
Interesting feature. Please check the CI.
Comment on lines
+10
to
+11
| def setUp(self): | ||
| super().setUp() |
There was a problem hiding this comment.
Why not in the setUpClass method?
Author
There was a problem hiding this comment.
Changes done.
The reason was to ensure consistency, given that even in version 19.0 ‘setUp’ is used:
https://github.com/OCA/mis-builder/blob/19.0/mis_builder/tests/test_aep.py#L23-L24
but if it doesn't bother anyone, I'm replacing it with our test creation method, which yields better results:
carlosdauden
force-pushed
the
15.0-ADD-mis_report_account_coverage_check
branch
from
July 26, 2026 16:26
34e21af to
36047d4
Compare
Wizard that, given a MIS report instance and an account-code range, detects accounts posted to during the report's period(s) that are not referenced by any KPI expression of the report -- e.g. to find why a balance sheet built with mis_builder doesn't balance.
carlosdauden
force-pushed
the
15.0-ADD-mis_report_account_coverage_check
branch
from
July 26, 2026 16:55
36047d4 to
32ad72f
Compare
Member
|
Can you move this PR to oca/mis-builder-contrib? You may also want to have a look at #785 which is almost ready to merge, and seem to address a similar use case. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wizard that, given a MIS report instance and an account-code range, detects accounts posted to during the report's period(s) that are not referenced by any KPI expression of the report -- e.g. to find why a balance sheet built with mis_builder doesn't balance.
@Tecnativa
ping @sergio-teruel @carlos-lopez-tecnativa @victoralmau